Issue metadata
Sign in to add a comment
|
2%-2.4% regression in page_cycler.intl_es_fr_pt-BR at 397225:397254 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 3 2016
=== Auto-CCing suspected CL author wangxianzhu@chromium.org === Hi wangxianzhu@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Track DisplayItemClient aliveness for each PaintController Author : wangxianzhu Commit description: After CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS was enabled, we didn't get crashes in DisplayItemClient::~DisplayItemClient() when the DisplayItemClient should be alive. We still get crashes in PaintController::updateCacheGeneration() [1] which indicates that we still have short-lived DisplayItemClient but not catched by aliveness checking. This might happen if there are multiple PaintControllers (e.g. one created by SkPictureBuilder and another by GraphicsLayer). Separately track DisplayItemClient aliveness for each PaintController in order to catch the issue. [1] https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.ptype%3D%27renderer%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%20like%20%27blink%3A%3APaintController%3A%3A%25%27%20AND%20product.version%3D%2753.0.2751.0%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&stbtiq=&reportid=20bc8a5c00000000&index=2#4 BUG=609218 Review-Url: https://codereview.chromium.org/2031623002 Cr-Commit-Position: refs/heads/master@{#397243} Commit : 53559da8fd5faa99d30a00eadbc6da3aebbde2b1 Date : Wed Jun 01 21:16:57 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@397224 3833.21 16.8794 6 good chromium@397239 3821.18 16.4382 5 good chromium@397241 3821.47 20.2616 5 good chromium@397242 3830.94 10.3961 4 good chromium@397243 3890.42 15.9632 5 bad <-- chromium@397247 3879.53 21.9652 5 bad chromium@397254 3905.32 15.0806 5 bad Bisect job ran on: android_nexus5_perf_bisect Bug ID: 616941 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.intl_es_fr_pt-BR Test Metric: warm_times/page_load_time Relative Change: 1.95% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3715 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9010926746368303184 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5833776291119104 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jun 3 2016
This is temporary. Will disable the code in release build soon.
,
Jun 10 2016
,
Jun 28 2016
Restored.
,
Jun 28 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by briander...@chromium.org
, Jun 2 2016