Issue metadata
Sign in to add a comment
|
237.3%-243.2% regression in v8.infinite_scroll at 397186:397215 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 6 2016
===== BISECT JOB RESULTS ===== Status: completed === Bisection aborted === The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression. Please contact the the team (see below) if you believe this is in error. === Warnings === The following warnings were raised by the bisect job: * Bisect failed to reproduce the regression with enough confidence. ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@397185 2.31331 1.28241 12 good chromium@397215 3.87364 1.03305 12 bad Bisect job ran on: android_nexus9_perf_bisect Bug ID: 616939 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests v8.infinite_scroll Test Metric: Animation-v8-gc-incremental-step_avg/flickr Relative Change: 65.39% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/1868 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007863718931094528 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5788632271552512 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 7 2016
=== Auto-CCing suspected CL author machenbach@chromium.org === Hi machenbach@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of [crankshaft] Only exclude explicit 'arguments' (and 'this') from liveness analysis. (patchset #2 id:20001 of https://codereview.chromium.org/2026173003/ ) Author : machenbach Commit description: Reason for revert: Triggers crashes on the deopt fuzzer: https://build.chromium.org/p/client.v8/builders/V8%20Deopt%20Fuzzer/builds/10608 Repro: out/Release/d8 --test --random-seed=849179141 --deopt-every-n-times 149 --nohard-abort --nodead-code-elimination --nofold-constants --noconcurrent-recompilation test/webkit/resources/standalone-pre.js test/webkit/dfg-arguments-mixed-alias.js test/webkit/resources/standalone-post.js Original issue's description: > [crankshaft] Only exclude explicit 'arguments' (and 'this') from liveness analysis. > > Currently, we do not emit EnvironmentMarkers if the hydrogen value > in the environment is arguments object. As the hydrogen value can change > for local variables, we emit only some environment markers. That can > cause environment liveness analysis to mark part of live range as live > and part as dead. The zapping phase then only inserts zaps in > live->dead transitions, potentially zapping a live value. > > With this CL, we only emit EnvironmentMarkers for 'this' and > 'arguments' local variables, disregarding the hydrogen value. > > BUG= chromium:612146 > LOG=n > > Committed: https://crrev.com/1428fbe224dc2df0cb6f59e4959430f7aa614064 > Cr-Commit-Position: refs/heads/master@{#36641} TBR=jkummerow@chromium.org,jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= chromium:612146 Review-Url: https://codereview.chromium.org/2029563002 Cr-Commit-Position: refs/heads/master@{#36644} Commit : 8b0a6dd6522f0253f6a7301d32e53ff7873a0238 Date : Wed Jun 01 12:45:06 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@397185 1.50694 0.713755 12 good chromium@397185,v8@dc78e0d4d7 2.03703 0.96026 8 good chromium@397185,v8@8b0a6dd652 3.66961 1.32408 8 bad <-- chromium@397185,v8@32820ddf92 3.29839 1.05114 8 bad chromium@397186 4.18022 1.06634 8 bad chromium@397187 3.84477 1.62335 6 bad chromium@397189 4.71847 1.05622 8 bad chromium@397193 3.33995 1.0365 12 bad chromium@397200 3.39987 1.33198 8 bad chromium@397215 4.11876 0.691823 8 bad Bisect job ran on: android_nexus9_perf_bisect Bug ID: 616939 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests v8.infinite_scroll Test Metric: Animation-v8-gc-incremental-step_avg/flickr Relative Change: 133.69% Score: 99.5 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/1869 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007863711854861808 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5245542246907904 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 7 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 15 2016
jarin, looks like a revert of your CL made these tests regress (and also noisier). Does that sound right? Is a reland possible?
,
Jul 19 2016
This has been actually relanded. This should not really affect noise, it is a small correctness fix; I am surprised it has any preformance impact at all.
,
Jul 29 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9005787289808755952
,
Jul 29 2016
Lets double check the bisect found the right patch. Trying another with more iterations.
,
Jul 29 2016
===== BISECT JOB RESULTS ===== Status: completed === Bisection aborted === The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression. Please contact the the team (see below) if you believe this is in error. === Warnings === The following warnings were raised by the bisect job: * Bisect failed to reproduce the regression with enough confidence. ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@397000 3.17292 2.26716 12 good chromium@397300 2.85038 3.22683 8 bad Bisect job ran on: android_nexus9_perf_bisect Bug ID: 616939 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests v8.infinite_scroll Test Metric: Animation-v8-gc-incremental-step_max/flickr Relative Change: 22.50% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/1938 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005787289808755952 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5799181491372032 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Aug 16 2016
I am not sure what to do about this bug - it is extremely unlikely it is my change. It is possible that https://crrev.com/dc78e0d4d7f8e67d99165ee4fc5cc118e1be2a9f caused the regression.
,
Sep 23 2016
hlopko, could you take a look at #10 and see if your patch could be related? In the meantime, more bisects...
,
Sep 23 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9000685559827921904
,
Sep 23 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9000685554170105328
,
Sep 24 2016
===== BISECT JOB RESULTS ===== Status: failed ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@397185 3.0 2.00713 8 good Bisect job ran on: android_nexus9_perf_bisect Bug ID: 616939 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests v8.infinite_scroll Test Metric: Animation-v8-gc-incremental-step_pct_090/flickr Relative Change: 116.88% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/2122 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9000685554170105328 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5852316408741888 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Sep 24 2016
===== BISECT JOB RESULTS ===== Status: completed === Bisection aborted === The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression. Please contact the the team (see below) if you believe this is in error. === Warnings === The following warnings were raised by the bisect job: * Bisect failed to reproduce the regression with enough confidence. ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@397185 1.40199 1.30726 17 good chromium@397215 2.39033 1.70596 19 bad Bisect job ran on: android_nexus9_perf_bisect Bug ID: 616939 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests v8.infinite_scroll Test Metric: Animation-v8-gc-incremental-step_avg/flickr Relative Change: 143.62% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/2123 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9000685559827921904 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=4993560649138176 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Oct 5 2016
Fixit ping. hlopko: can you please look at comment #10 and see if your patch could be related to this regression? I'll kick off another bisect in the meantime.
,
Oct 5 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8999612939222700128
,
Oct 6 2016
Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/2159 Failure reason: the build has failed due to infrastructure failure.
,
Oct 6 2016
Hi, the patch was reverted (as not needed anymore) by mlippautz@ yesterday: https://codereview.chromium.org/2397713002
,
Oct 17 2016
Closing this. See #19. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by briander...@chromium.org
, Jun 2 2016