New issue
Advanced search Search tips

Issue 616920 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

mash: Message center needs to parent windows correctly

Project Member Reported by jamescook@chromium.org, Jun 2 2016

Issue description

See https://codereview.chromium.org/2033833002/ for details.

Code in //ui/message_center/views, specifically MessagePopupCollection, needs to
be able to parent windows to a container. It uses a NativeWindow for this. However, on mash we need to use a mus::Window container, even though NativeWindow is still an aura::Window.

The code is shared with desktop Chrome for showing notifications. Desktop Chrome does not provide a parent container, since these are shown over the desktop. I might be able to do something like:

* Pass an integer container_id into here.
* Add a client interface somewhere in //ui/views that can convert a
container_id into a void* parent.
* Depending on whether or not mus is running, cast the void* parent to
either an aura::Window (and assign to Widget::InitParams::parent) or to
a mus::Window (and assign to Widget::InitParams::parent_mus).

But that seems pretty distasteful.

 
Components: Internals>MUS
Labels: Proj-Mustash
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Comment 4 by est...@chromium.org, Jun 28 2018

Status: WontFix (was: Untriaged)
I think this is obsolete.

Sign in to add a comment