New issue
Advanced search Search tips

Issue 616905 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 585247
Owner: ----
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 477150



Sign in to add a comment

history.back() has different behavior with --site-per-process (in cross-origin-redirect-on-back.html layout test)

Project Member Reported by lukasza@chromium.org, Jun 2 2016

Issue description

Repro:
$ ninja -C out/gn ... blink_tests
$ third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn -v --no-retry-failures --additional-drt-flag=--no-sandbox --additional-drt-flag=--site-per-process http/tests/history/cross-origin-redirect-on-back.html

Without --site-per-process printf logging shows that the following pages load:

Main/script: location=http://127.0.0.1:8000/history/cross-origin-redirect-on-back.html
Main/onload: location=http://127.0.0.1:8000/history/cross-origin-redirect-on-back.html
Back/script: location=http://127.0.0.1:8000/history/resources/back.html
Back/script: location=http://localhost:8000/history/resources/back.html
Main/script: location=http://127.0.0.1:8000/history/cross-origin-redirect-on-back.html#back
Main/onload: location=http://127.0.0.1:8000/history/cross-origin-redirect-on-back.html#back

With --site-per-process it seems that history.back from the last frame doesn't have an effect and the test times out:

Main/script: location=http://127.0.0.1:8000/history/cross-origin-redirect-on-back.html
Main/onload: location=http://127.0.0.1:8000/history/cross-origin-redirect-on-back.html
Back/script: location=http://127.0.0.1:8000/history/resources/back.html
Back/script: location=http://localhost:8000/history/resources/back.html
Back/script: location=http://127.0.0.1:8000/history/resources/back.html ?????
 
Cc: creis@chromium.org
Charlie, since this is related to the session history, I wonder if you could take an initial look at it?
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c224308eb9edb880244751255280498c49b8219

commit 8c224308eb9edb880244751255280498c49b8219
Author: lukasza <lukasza@chromium.org>
Date: Tue Jun 14 16:45:58 2016

Assigning specific bugs to layout test failures in --site-per-process mode.

BUG= 616905 ,  619662 

Review-Url: https://codereview.chromium.org/2065693002
Cr-Commit-Position: refs/heads/master@{#399727}

[modify] https://crrev.com/8c224308eb9edb880244751255280498c49b8219/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c224308eb9edb880244751255280498c49b8219

commit 8c224308eb9edb880244751255280498c49b8219
Author: lukasza <lukasza@chromium.org>
Date: Tue Jun 14 16:45:58 2016

Assigning specific bugs to layout test failures in --site-per-process mode.

BUG= 616905 ,  619662 

Review-Url: https://codereview.chromium.org/2065693002
Cr-Commit-Position: refs/heads/master@{#399727}

[modify] https://crrev.com/8c224308eb9edb880244751255280498c49b8219/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Comment 4 by nasko@chromium.org, Dec 7 2016

Related/same to  issue 585247 ?
Mergedinto: 585247
Status: Duplicate (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62db39d8dec89187c2518d0046b7ca28d9fc747d

commit 62db39d8dec89187c2518d0046b7ca28d9fc747d
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Oct 04 23:23:03 2017

Disable exceptions for tests that have "healed" themselves.

Bug:  758075 ,  700535 ,  582522 ,  602497 ,  616905 
Bug:  623268 ,  623265 ,  678492 
Change-Id: I1bdc648c9aeb97cc1d16b0d8693d04e0c76030de
Reviewed-on: https://chromium-review.googlesource.com/700983
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506557}
[modify] https://crrev.com/62db39d8dec89187c2518d0046b7ca28d9fc747d/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Sign in to add a comment