Extension crash when click Chrome's stop sharing dialog |
|||||||||
Issue descriptionVersion: 52.0.2739.0 Steps: 1. Cast entire desktop to Chromecast 2. Click Stop sharing blue button in dialog that pops up along taskbar at bottom of screen. Expected: Receiver immediately tears down session returning to home screen. Sender clears activity immediately as well. Actual: receiver does not immediately return to homescreen. After ~ 10 seconds, a blue error screen appears and then the homescreen.
,
Jun 4 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4ef1a4e478937783c303b8a712e9fef0457ac60 commit c4ef1a4e478937783c303b8a712e9fef0457ac60 Author: xjz <xjz@chromium.org> Date: Mon Jun 06 18:34:27 2016 Avoid double deleting from |MediaStreamDispatcher::label_stream_map_|. MediaStreamDispatcher::OnDeviceStopped() may delete the same element twice from |label_stream_map_| and causes the crash. BUG= 616884 Review-Url: https://codereview.chromium.org/2035993002 Cr-Commit-Position: refs/heads/master@{#398075} [modify] https://crrev.com/c4ef1a4e478937783c303b8a712e9fef0457ac60/content/renderer/media/media_stream_dispatcher.cc
,
Jun 6 2016
We should merge this crash fix into M52.
,
Jun 7 2016
,
Jun 7 2016
,
Jun 7 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 8 2016
Please merge the CL in to M52 branch asap so that it gets picked for next beta promotion scheduled on 06/15.
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a279df07994a42c625120bbf20d7f3d4c67f4197 commit a279df07994a42c625120bbf20d7f3d4c67f4197 Author: Yuri Wiitala <miu@chromium.org> Date: Wed Jun 08 21:30:35 2016 Avoid double deleting from |MediaStreamDispatcher::label_stream_map_|. MediaStreamDispatcher::OnDeviceStopped() may delete the same element twice from |label_stream_map_| and causes the crash. BUG= 616884 TBR=xjz@chromium.org Review-Url: https://codereview.chromium.org/2035993002 Cr-Commit-Position: refs/heads/master@{#398075} (cherry picked from commit c4ef1a4e478937783c303b8a712e9fef0457ac60) Review URL: https://codereview.chromium.org/2049293002 . Cr-Commit-Position: refs/branch-heads/2743@{#285} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/a279df07994a42c625120bbf20d7f3d4c67f4197/content/renderer/media/media_stream_dispatcher.cc
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a279df07994a42c625120bbf20d7f3d4c67f4197 commit a279df07994a42c625120bbf20d7f3d4c67f4197 Author: Yuri Wiitala <miu@chromium.org> Date: Wed Jun 08 21:30:35 2016 Avoid double deleting from |MediaStreamDispatcher::label_stream_map_|. MediaStreamDispatcher::OnDeviceStopped() may delete the same element twice from |label_stream_map_| and causes the crash. BUG= 616884 TBR=xjz@chromium.org Review-Url: https://codereview.chromium.org/2035993002 Cr-Commit-Position: refs/heads/master@{#398075} (cherry picked from commit c4ef1a4e478937783c303b8a712e9fef0457ac60) Review URL: https://codereview.chromium.org/2049293002 . Cr-Commit-Position: refs/branch-heads/2743@{#285} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/a279df07994a42c625120bbf20d7f3d4c67f4197/content/renderer/media/media_stream_dispatcher.cc
,
Oct 6 2016
,
Oct 6 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by amp@chromium.org
, Jun 3 2016