New issue
Advanced search Search tips

Issue 616873 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 615836
Owner: ----
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

5% regression in chromium-rel-mac-retina/thread_times.tough_scrolling_cases/thread_total_all_cpu_time_per_frame in range 396221-396249

Project Member Reported by rsch...@chromium.org, Jun 2 2016

Issue description

Mergedinto: 615836
Status: Duplicate (was: Unconfirmed)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (patchset #1 id:1 of https://codereview.chromium.org/2006153002/ )
Author  : ccameron
Commit description:
  
Reason for revert:
The patch that this depended on, https://codereview.chromium.org/1993333002/, has landed.

Original issue's description:
> Revert of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (patchset #8 id:140001 of https://codereview.chromium.org/1984873002/ )
>
> Reason for revert:
> Depending on an implementation still in review. Results in flooding of LOG messages.
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=614155
> https://codereview.chromium.org/1993333002/
>
> Original issue's description:
> > Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources.
> >
> > The new logic will hold onto GpuMemoryBuffer Resources until they are no longer
> > in use by the Window Server.
> >
> > BUG= 608026 
> > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> >
> > Committed: https://crrev.com/87aa976eacd8ed0c530d32a7c85d6ba706dcabf6
> > Cr-Commit-Position: refs/heads/master@{#395150}
>
> TBR=ccameron@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 608026 
>
> Committed: https://crrev.com/aa5126ff66379a9060e87b010135f1aee7fc1ab2
> Cr-Commit-Position: refs/heads/master@{#395524}

TBR=erikchen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 608026 

Review-Url: https://codereview.chromium.org/2015923003
Cr-Commit-Position: refs/heads/master@{#396233}
Commit  : f8a942fbb35c30edcc88cfe859ceda7b469096af
Date    : Thu May 26 18:25:28 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N   Good?
chromium@396220  8.53478  0.11619   8   good
chromium@396228  8.51355  0.162455  12  good
chromium@396232  8.59754  0.145812  12  good
chromium@396233  8.85134  0.140361  8   bad    <--
chromium@396234  8.81476  0.124481  8   bad
chromium@396235  8.80405  0.13459   12  bad
chromium@396249  8.89489  0.11057   8   bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 616873

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.tough_scrolling_cases
Test Metric: thread_total_all_cpu_time_per_frame/thread_total_all_cpu_time_per_frame
Relative Change: 4.27%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1316
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9010935351559163872


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5865055195758592

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: -Performance-Sheriff-Regressions Performance-Sheriff

Sign in to add a comment