9% regression in ChromiumPerf/chromium-rel-mac-retina/startup.warm.blank_page/foreground_tab_load_complete in range 397027 - 397064 |
|||||||
Issue descriptionDidn't fire an automatic alert. Not sure why. https://chromeperf.appspot.com/report?sid=101b4d2357bdcb4c5143832638103c843d6b06bb88f55e72b8b5b27b7d8ec52f
,
Jul 1 2016
=== Auto-CCing suspected CL author ccameron@chromium.org === Hi ccameron@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Clean up the RWHVMac to ui::Compositor interface Author : ccameron Commit description: Move the "ui::Compositor's relationship to RWHVMac" state machine into BrowserCompositorViewMac. Clarify the state by renaming states from Active / Suspended / Destroyed to HasAttachedCompositor / HasDetachedCompositor / HasNoCompositor Change the thumbnailer's copy requests to be intercepted by the BrowserCompositorViewMac, and thereby have the copy request keep the ui::Compositor attached (even if the RenderWidgetHostImpl is hidden). BUG= 623716 Review-Url: https://codereview.chromium.org/2093113003 Cr-Commit-Position: refs/heads/master@{#402541} Commit : 9e8481c2e211439771d0634043d2addf9fe7b4ec Date : Tue Jun 28 21:07:43 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@402526 575.6 8.79204 5 good chromium@402539 571.0 2.0 5 good chromium@402540 575.2 1.09545 5 good chromium@402541 609.6 3.43511 5 bad <-- chromium@402543 617.8 6.53452 5 bad chromium@402546 621.8 11.9038 5 bad chromium@402552 625.0 10.2713 5 bad Bisect job ran on: mac_retina_perf_bisect Bug ID: 616871 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests startup.warm.blank_page Test Metric: foreground_tab_load_complete/foreground_tab_load_complete Relative Change: 8.58% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1377 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008311663014239616 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5862473631006720 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 1 2016
Title is wrong, bisect is right :) ccameron, can you take a look?
,
Jul 7 2016
Is this measuring the latency component ui::TAB_SHOW_COMPONENT? If so, that patch made the reporting of that number more accurate (so this is a change in what is being measured, not a change in the value).
,
Aug 22 2016
,
Aug 25 2016
,
Oct 13 2016
Got it. Closing per comment #4.
,
Feb 3 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rsch...@chromium.org
, Jul 1 2016