New issue
Advanced search Search tips

Issue 616868 link

Starred by 1 user
Status: Fixed
Owner:
nedngu...@google.com
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Range produced by ./tools/perf/diagnose_test_failure is not always correct

Project Member Reported by zh...@chromium.org, Jun 2 2016 
To reproduce, run the following:
$ ./tools/perf/diagnose_test_failure memory.blink_memory_mobile https://build.chromium.org
/p/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20%281%29/builds/2848


The output is:

Process https://build.chromium.org/p/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20%281%29/builds/2846 

First failure range: (395562, 397366) - 29 CLs
First failed build: https://build.chromium.org/p/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20%281%29/builds/2847



The correct range should be: (397341, 397365)
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c2a6b9263b98d77a176fa659f0682e04473ef9a

commit 1c2a6b9263b98d77a176fa659f0682e04473ef9a
Author: nednguyen <nednguyen@google.com>
Date: Thu Jun 02 23:28:11 2016

[tools/perf] Improve the regex to find the commited revision

Add "\n" to the begin of the regex that find commit revision so we don't match
text fields of the case of relanded revision got quoted.

BUG= 616868 
TBR=zhenw@chromium.org

Review-Url: https://codereview.chromium.org/2034573005
Cr-Commit-Position: refs/heads/master@{#397541}

[modify] https://crrev.com/1c2a6b9263b98d77a176fa659f0682e04473ef9a/tools/perf/diagnose_test_failure

Comment 2 by nedngu...@google.com, Jun 2 2016

Status: Fixed (was: Assigned)
Should be fixed.
►

Sign in to add a comment