What is mojo:ash_sysui is being folded into mojo:desktop_wm (will become mojo:ash). We need to fold the interesting parts of ash_sysui, at which point ash_sysui is no longer necessary.
I'll take this; WIP CL: https://codereview.chromium.org/2235493002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/462ce06a55632c364a0269eb7557ff588a5aa0c3 commit 462ce06a55632c364a0269eb7557ff588a5aa0c3 Author: msw <msw@chromium.org> Date: Wed Aug 10 02:06:14 2016 mash: Disable ash_sysui; begin removal. Do not start mojo:ash_sysui in "chrome --mash" sessions. (still runs ash (wm), quick_launch, exe:chrome, etc.) Remove ShelfLayout and UserWindow* mojoms and impls. (these were for mojo:ash_sysui<->mojo:ash communication) Move wallpaper.mojom to ash/public/interfaces. Nix RootWindowController::Get[Shelf|Status]LayoutManager. Other misc related cleanup. BUG= 616857 TEST=chrome --mash doesn't show a shelf, status or background (for now). R=sky@chromium.org TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2235493002 Cr-Commit-Position: refs/heads/master@{#410921} [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/mus/BUILD.gn [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/mus/root_window_controller.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/mus/root_window_controller.h [delete] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/ash/mus/shelf_layout_impl.cc [delete] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/ash/mus/shelf_layout_impl.h [delete] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/ash/mus/user_window_controller_impl.cc [delete] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/ash/mus/user_window_controller_impl.h [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/mus/window_manager_application.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/mus/window_manager_application.h [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/mus/window_manager_unittest.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/public/interfaces/BUILD.gn [delete] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/ash/public/interfaces/shelf_layout.mojom [delete] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/ash/public/interfaces/user_window_controller.mojom [rename] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/public/interfaces/wallpaper.mojom [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/sysui/BUILD.gn [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/sysui/manifest.json [delete] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/ash/sysui/public/interfaces/BUILD.gn [delete] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/ash/sysui/public/interfaces/OWNERS [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/sysui/shelf_delegate_mus.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/sysui/shelf_delegate_mus.h [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/sysui/sysui_application.h [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/sysui/user_wallpaper_delegate_mus.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/ash/sysui/user_wallpaper_delegate_mus.h [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/app/mash/BUILD.gn [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/app/mash/mash_runner.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/app/mojo/chrome_manifest.json [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/browser/chromeos/chrome_interface_factory.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/browser/ui/ash/DEPS [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/browser/ui/ash/chrome_wallpaper_manager.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/browser/ui/ash/chrome_wallpaper_manager.h [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/mash/session/BUILD.gn [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/mash/session/session.cc [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/mash/session/session.h [modify] https://crrev.com/462ce06a55632c364a0269eb7557ff588a5aa0c3/mash/unittests_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/828394031639b3305df4fbae8a41d6c730003262 commit 828394031639b3305df4fbae8a41d6c730003262 Author: msw <msw@chromium.org> Date: Tue Aug 30 18:57:29 2016 mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash. Migrate ash/sysui/shelf_delegate_mus.* to ash/mus. Move mash/shelf/public/interfaces to ash/public/interfaces. Merge shelf_constants.mojom and shelf.mojom. Add ShelfController/ShelfObserver multi-display support. Add ShelfObserver::OnShelfCreated mojo interface. Add EnumTraits for alignment and auto-hide behavior. Remove redundant ash/shelf_layout_manager* Inline RootWindowController::OnShelfWindowAvailable. BUG= 557406 , 614182 , 615155 , 616857 TEST=Mash shelf shows chrome icon; no cros changes. R=jamescook@chromium.org,sky@chromium.org TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2259153002 Cr-Commit-Position: refs/heads/master@{#415378} [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/BUILD.gn [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/DEPS [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/root_window_controller.cc [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/root_window_controller.h [add] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/shelf_delegate_mus.cc [add] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/shelf_delegate_mus.h [delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/ash/mus/shelf_layout_manager.cc [delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/ash/mus/shelf_layout_manager.h [delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/ash/mus/shelf_layout_manager_delegate.h [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/shell_delegate_mus.cc [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/test/wm_test_helper.cc [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/window_manager_application.cc [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/mus/window_manager_application.h [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/public/interfaces/BUILD.gn [rename] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/public/interfaces/shelf.mojom [add] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/public/interfaces/shelf.typemap [add] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/public/interfaces/shelf_enum_traits.h [add] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/public/interfaces/typemaps.gni [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/sysui/BUILD.gn [delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/ash/sysui/shelf_delegate_mus.cc [delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/ash/sysui/shelf_delegate_mus.h [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/sysui/shell_delegate_mus.cc [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/sysui/sysui_application.cc [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/ash/sysui/sysui_application.h [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/chrome/app/mojo/chrome_manifest.json [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.h [delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/mash/shelf/public/interfaces/BUILD.gn [delete] https://crrev.com/316099ac4e77dabe98f7ea49cf5fdccab6f93876/mash/shelf/public/interfaces/shelf_constants.mojom [modify] https://crrev.com/828394031639b3305df4fbae8a41d6c730003262/mojo/public/tools/bindings/chromium_bindings_configuration.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05 commit 2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05 Author: msw <msw@chromium.org> Date: Tue Sep 13 06:03:23 2016 mash: Port ash_sysui app list presenter to mojo:ash. Move app_list_presenter_mus.* to ash/mus. Remove mus display id workaround; cleanup. BUG= 607300 , 616857 TEST=Chrome --mash shows app list. R=sky@chromium.org,mfomitchev@chromium.org Review-Url: https://codereview.chromium.org/2335833002 Cr-Commit-Position: refs/heads/master@{#418181} [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/BUILD.gn [rename] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/app_list_presenter_mus.cc [rename] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/app_list_presenter_mus.h [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/manifest.json [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/shell_delegate_mus.cc [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/shell_delegate_mus.h [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/window_manager.cc [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/sysui/BUILD.gn [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/sysui/manifest.json [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/sysui/shell_delegate_mus.cc [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/sysui/shell_delegate_mus.h [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/sysui/sysui_application.cc [modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/chrome/app/mojo/chrome_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15156bf5e576f3894a1eac72f2802f88ca59dd43 commit 15156bf5e576f3894a1eac72f2802f88ca59dd43 Author: msw <msw@chromium.org> Date: Tue Sep 13 21:49:17 2016 mash: Port KeyboardUIMus to mojo:ash; remove sysui. Move ash/sysui/keyboard_ui_mus.* to ash/mus. Instantiate KeyboardUIMus from WmShellMus. Avoid null pointer access in mash_unittests. Cleanup [AshWindowTreeHost|Shell]InitParams. Remove Shell::in_mus_ and accessor. Remove ash/sysui directory and contents. BUG= 616857 TEST=No ChromeOS keyboard changes. R=sky@chromium.org TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2339633002 Cr-Commit-Position: refs/heads/master@{#418381} [modify] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/ash/BUILD.gn [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/host/ash_window_tree_host_init_params.cc [modify] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/ash/host/ash_window_tree_host_init_params.h [modify] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/ash/mus/BUILD.gn [modify] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/ash/mus/bridge/wm_shell_mus.cc [rename] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/ash/mus/keyboard_ui_mus.cc [rename] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/ash/mus/keyboard_ui_mus.h [modify] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/ash/root_window_controller.cc [modify] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/ash/shell.cc [modify] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/ash/shell.h [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/shell_init_params.cc [modify] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/ash/shell_init_params.h [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/BUILD.gn [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/DEPS [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/README.md [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/main.cc [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/manifest.json [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/shell_delegate_mus.cc [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/shell_delegate_mus.h [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/stub_context_factory.cc [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/stub_context_factory.h [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/sysui_application.cc [delete] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/ash/sysui/sysui_application.h [modify] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43/tools/determinism/compare_build_artifacts.py
Comment 1 by sky@chromium.org
, Jun 2 2016