New issue
Advanced search Search tips

Issue 616836 link

Starred by 1 user
Status: Fixed
Owner:
nzolghadr@chromium.org
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 603566



Sign in to add a comment

Creating a KeyboardEventManager class

Project Member Reported by nzolghadr@chromium.org, Jun 2 2016 
We should create a dedicated keyboard event class taking care of firing keyboard events and any states that are necessary and take out the logic from EventHandler.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68da48f3c013555d779a0a0c86634e53dfb65ce4

commit 68da48f3c013555d779a0a0c86634e53dfb65ce4
Author: nzolghadr <nzolghadr@chromium.org>
Date: Wed Jun 08 21:18:04 2016

Create a KeyboardEventManager class

Extract Keyboard related logic and events from
EventHandler and put it in a dedicate class.

BUG= 616836 

Review-Url: https://codereview.chromium.org/2036643003
Cr-Commit-Position: refs/heads/master@{#398678}

[modify] https://crrev.com/68da48f3c013555d779a0a0c86634e53dfb65ce4/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/68da48f3c013555d779a0a0c86634e53dfb65ce4/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/68da48f3c013555d779a0a0c86634e53dfb65ce4/third_party/WebKit/Source/core/input/EventHandler.h
[add] https://crrev.com/68da48f3c013555d779a0a0c86634e53dfb65ce4/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[add] https://crrev.com/68da48f3c013555d779a0a0c86634e53dfb65ce4/third_party/WebKit/Source/core/input/KeyboardEventManager.h
[modify] https://crrev.com/68da48f3c013555d779a0a0c86634e53dfb65ce4/third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp
[modify] https://crrev.com/68da48f3c013555d779a0a0c86634e53dfb65ce4/third_party/WebKit/Source/platform/PlatformKeyboardEvent.h
[modify] https://crrev.com/68da48f3c013555d779a0a0c86634e53dfb65ce4/third_party/WebKit/Source/web/WebAXObject.cpp

Comment 2 by nzolghadr@chromium.org, Jun 9 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment