New issue
Advanced search Search tips

Issue 616831 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Option for Proguard jars to be switched

Project Member Reported by smaier@chromium.org, Jun 2 2016

Issue description

Allow swapping of the proguard.jar used for shrinking the Android application. By default, we will still use the one in //third_party/proguard, but we might want a new/different version of Proguard in the future.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6174a5f8b59fcfd3dbc7273faa27851cea6c9467

commit 6174a5f8b59fcfd3dbc7273faa27851cea6c9467
Author: smaier <smaier@chromium.org>
Date: Fri Jun 10 13:33:02 2016

Adding option for Proguard jar to be switched.

Additionally, adds the is_java_debug gn arg, which can now be set
separately from is_debug, which will control Java specific debug
features, such as Proguard, multidexing, and incremental dexing.

BUG= 616831 , 615082 , 615083 

Review-Url: https://codereview.chromium.org/2031033002
Cr-Commit-Position: refs/heads/master@{#399172}

[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/android_webview/system_webview_apk_tmpl.gni
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/base/BUILD.gn
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/base/android/java/templates/BuildConfig.template
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/build/config/android/config.gni
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/build/config/android/internal_rules.gni
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/build/config/android/rules.gni
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/chrome/android/BUILD.gn
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/components/cronet/android/BUILD.gn

Comment 2 by smaier@chromium.org, Jun 13 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6174a5f8b59fcfd3dbc7273faa27851cea6c9467

commit 6174a5f8b59fcfd3dbc7273faa27851cea6c9467
Author: smaier <smaier@chromium.org>
Date: Fri Jun 10 13:33:02 2016

Adding option for Proguard jar to be switched.

Additionally, adds the is_java_debug gn arg, which can now be set
separately from is_debug, which will control Java specific debug
features, such as Proguard, multidexing, and incremental dexing.

BUG= 616831 , 615082 , 615083 

Review-Url: https://codereview.chromium.org/2031033002
Cr-Commit-Position: refs/heads/master@{#399172}

[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/android_webview/system_webview_apk_tmpl.gni
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/base/BUILD.gn
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/base/android/java/templates/BuildConfig.template
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/build/config/android/config.gni
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/build/config/android/internal_rules.gni
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/build/config/android/rules.gni
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/chrome/android/BUILD.gn
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java
[modify] https://crrev.com/6174a5f8b59fcfd3dbc7273faa27851cea6c9467/components/cronet/android/BUILD.gn

Comment 4 by smaier@chromium.org, Jun 22 2016

Status: Started (was: Fixed)
Status: Fixed (was: Started)

Sign in to add a comment