New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616816 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
User never visited
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Feature : check in imageloader

Project Member Reported by ashishgaurav@chromium.org, Jun 2 2016

Issue description

Feature : check in imageloader
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/7a5be50747844b40ec184b4ac1b6a22ac2403a41

commit 7a5be50747844b40ec184b4ac1b6a22ac2403a41
Author: Ashish Gaurav <ashishgaurav@google.com>
Date: Thu Jun 02 20:13:03 2016

full.xml: add src/platform/imageloader

BUG=chromium:616816
TEST=repo sync gets src/platform/imageloader
Change-Id: I1ad639feec70996248c3c2593113c03c65e4abfd
Reviewed-on: https://chromium-review.googlesource.com/349270
Commit-Ready: Ashish Gaurav <ashishgaurav@chromium.org>
Tested-by: Ashish Gaurav <ashishgaurav@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7a5be50747844b40ec184b4ac1b6a22ac2403a41/full.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/imageloader/+/d5eb65afd5f9da10a3fa86f65d357a817221717e

commit d5eb65afd5f9da10a3fa86f65d357a817221717e
Author: Ashish Gaurav <ashishgaurav@google.com>
Date: Fri May 27 22:43:45 2016

initial revision for imageloader

- also add unit tests (run them by FEATURES="test" emerge-${BOARD} ...)

BUG=chromium:616816
TEST=emerge-cyan chromeos-base/imageloader && cros deploy <ip for cyan> chromeos-base/imageloader
Change-Id: Idb3593ac65a83dedb85d78c42104d1b4ead5c7e0
Reviewed-on: https://chromium-review.googlesource.com/348080
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Ashish Gaurav <ashishgaurav@chromium.org>
Tested-by: Ashish Gaurav <ashishgaurav@chromium.org>

[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/imageloadclient.h
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/imageloader.gyp
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/imageloadclient.cc
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/run_tests.cc
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/imageloader.cc
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/imageloadclient-glue.xml
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/org.chromium.ImageLoader.service
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/imageloader_common.h
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/imageloader_common.cc
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/imageloader.h
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/imageloader-glue.xml
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/README.md
[add] https://crrev.com/d5eb65afd5f9da10a3fa86f65d357a817221717e/org.chromium.ImageLoader.conf

Comment 3 by adlr@google.com, Jun 13 2016

Close this?
Waiting for the ebuild check in.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/9dad5c26f12cf833f0d6add379dfe420396bf0ee

commit 9dad5c26f12cf833f0d6add379dfe420396bf0ee
Author: Ashish Gaurav <ashishgaurav@google.com>
Date: Thu Jun 02 20:27:35 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a818e0c59851a842c53aaa73e021d3b0bf2a7490

commit a818e0c59851a842c53aaa73e021d3b0bf2a7490
Author: Ashish Gaurav <ashishgaurav@google.com>
Date: Thu Jun 02 01:00:15 2016

imageloader: new ebuild

BUG=chromium:616816
TEST="emerge-cyan chromeos-base/imageloader" builds fine when src/platform/imageloader has build files (still in code
review)
Change-Id: I3cc54d005d3eb4b2b7f9ec35efd4f1c5f525340d
Reviewed-on: https://chromium-review.googlesource.com/348941
Commit-Ready: Ashish Gaurav <ashishgaurav@chromium.org>
Tested-by: Ashish Gaurav <ashishgaurav@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[add] https://crrev.com/a818e0c59851a842c53aaa73e021d3b0bf2a7490/chromeos-base/imageloader/imageloader-9999.ebuild

Components: Platform

Sign in to add a comment