New issue
Advanced search Search tips

Issue 616813 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS , Mac
Pri: 3
Type: Bug

Blocking:
issue 621726



Sign in to add a comment

Get rid of gyp-mac-tool

Project Member Reported by rsesek@chromium.org, Jun 2 2016

Issue description

In GN we shouldn't rely on gyp-mac-tool. Much of the functionality has already been replaced with scripts in //build/config/mac and //build/toolchain/mac (and ios), but there are a few remaining tools that we use and that should be converted.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17dd77eb2af78643ffeb32bbb2ee48c2d22106e7

commit 17dd77eb2af78643ffeb32bbb2ee48c2d22106e7
Author: sdefresne <sdefresne@chromium.org>
Date: Thu Jun 02 18:15:58 2016

[GN] Add script to compile assets catalog without using tools/gyp.

Implement the assets catalog compilation without using mac_tool.py
from tools/gyp in order to make //build independent from the rest
of Chromium checkout.

BUG= 616813 

Review-Url: https://codereview.chromium.org/2023223002
Cr-Commit-Position: refs/heads/master@{#397469}

[modify] https://crrev.com/17dd77eb2af78643ffeb32bbb2ee48c2d22106e7/build/toolchain/mac/BUILD.gn
[add] https://crrev.com/17dd77eb2af78643ffeb32bbb2ee48c2d22106e7/build/toolchain/mac/compile_xcassets.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88e841406ed2bcd559882c79ef254dac12f9c2a3

commit 88e841406ed2bcd559882c79ef254dac12f9c2a3
Author: rsesek <rsesek@chromium.org>
Date: Fri Jun 03 19:08:52 2016

[Mac/iOS/GN] Add //build/toolchain/mac/filter_libtool.py.

This moves another step performed by gyp-mac-tool into a standalone script.

BUG= 616813 
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2033503003
Cr-Commit-Position: refs/heads/master@{#397770}

[modify] https://crrev.com/88e841406ed2bcd559882c79ef254dac12f9c2a3/build/toolchain/mac/BUILD.gn
[add] https://crrev.com/88e841406ed2bcd559882c79ef254dac12f9c2a3/build/toolchain/mac/filter_libtool.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51dc7dae178061bfcc559f16d85e43f2695efacf

commit 51dc7dae178061bfcc559f16d85e43f2695efacf
Author: rsesek <rsesek@chromium.org>
Date: Thu Jun 09 15:13:31 2016

[Mac/GN] Add //build/config/mac/package_framework.py.

This moves another step performed by gyp-mac-tool into a standalone script. In
addition, support for more top-level bundle directories (e.g. Helpers, XPCServices,
etc.) is added.

BUG= 616813 , 604809 
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2055673002
Cr-Commit-Position: refs/heads/master@{#398884}

[modify] https://crrev.com/51dc7dae178061bfcc559f16d85e43f2695efacf/build/config/mac/base_rules.gni
[add] https://crrev.com/51dc7dae178061bfcc559f16d85e43f2695efacf/build/config/mac/package_framework.py

Comment 4 Deleted

Blocking: 621726

Comment 6 by rsesek@chromium.org, Jun 21 2016

Owner: rsesek@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc86361978c030bac431d9745c2de6a8eed6d014

commit fc86361978c030bac431d9745c2de6a8eed6d014
Author: rsesek <rsesek@chromium.org>
Date: Wed Jun 22 08:13:27 2016

[iOS/GN] Replace the last to gyp-mac-tool commands with standalone scripts.

This adds write_framework_hmap.py and write_framework_modulemap.py under
//build/config/ios/.

BUG= 616813 
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2082573006
Cr-Commit-Position: refs/heads/master@{#401228}

[modify] https://crrev.com/fc86361978c030bac431d9745c2de6a8eed6d014/build/config/ios/rules.gni
[add] https://crrev.com/fc86361978c030bac431d9745c2de6a8eed6d014/build/config/ios/write_framework_hmap.py
[add] https://crrev.com/fc86361978c030bac431d9745c2de6a8eed6d014/build/config/ios/write_framework_modulemap.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6ab13319cf869060624f7ade7f4f952e7f95ea7

commit d6ab13319cf869060624f7ade7f4f952e7f95ea7
Author: rsesek <rsesek@chromium.org>
Date: Wed Jun 22 16:28:10 2016

[Mac/iOS/GN] Remove setup_toolchain.py since gyp-mac-tool is not needed anymore.

BUG= 616813 
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2081933004
Cr-Commit-Position: refs/heads/master@{#401300}

[modify] https://crrev.com/d6ab13319cf869060624f7ade7f4f952e7f95ea7/build/toolchain/mac/BUILD.gn
[delete] https://crrev.com/07025e9df358bb0249550d6124b9817333421fc0/build/toolchain/mac/setup_toolchain.py

Comment 9 by rsesek@chromium.org, Jun 22 2016

Status: Fixed (was: Started)

Sign in to add a comment