New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616812 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Cronet crash with net::QuicChromiumClientSession::StreamRequest

Project Member Reported by mef@chromium.org, Jun 2 2016

Issue description

Version: M52
OS: Android

See b/28676259 for details

Here is the symbolicated crash stack:
********** Crash dump: **********
5-07 15:26:26.021 F/libc    (23234): Fatal signal 11 (SIGSEGV), code 1, fault addr 0x3b4 in tid 26695 (ChromiumNet)
05-07 15:26:26.077 F/DEBUG   (  190): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
05-07 15:26:26.077 F/DEBUG   (  190): Build fingerprint: 'google/razor/flo:6.0.1/MOB30D/2704746:user/release-keys'
05-07 15:26:26.078 F/DEBUG   (  190): Revision: '0'
05-07 15:26:26.078 F/DEBUG   (  190): ABI: 'arm'
05-07 15:26:26.078 F/DEBUG   (  190): pid: 23234, tid: 26695, name: ChromiumNet  >>> com.google.android.googlequicksearchbox:search <<<
05-07 15:26:26.078 F/DEBUG   (  190): signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x3b4
05-07 15:26:26.136 F/DEBUG   (  190):     r0 00000000  r1 9aecfb64  r2 9aecfb78  r3 00000000
05-07 15:26:26.136 F/DEBUG   (  190):     r4 9aecfb64  r5 9aecfb78  r6 9ba58508  r7 9aecfb54
05-07 15:26:26.136 F/DEBUG   (  190):     r8 9bc67901  r9 9bc677e7  sl 9bc67901  fp 9bc677e7
05-07 15:26:26.138 F/DEBUG   (  190):     ip 9d196030  sp 9ba584d0  lr 9bb564af  pc 9bb56048  cpsr 600d0030
05-07 15:26:26.195 F/DEBUG   (  190):
05-07 15:26:26.195 F/DEBUG   (  190): backtrace:
05-07 15:26:26.195 F/DEBUG   (  190):     #00 pc libcronet.so: 000fd048: net::QuicChromiumClientSession::TryCreateStream(net::QuicChromiumClientSession::StreamRequest*, net::QuicChromiumClientStream**)+2
05-07 15:26:26.195 F/DEBUG   (  190):     #01 pc libcronet.so: 000fd4aa: net::QuicChromiumClientSession::StreamRequest::StartRequest(base::WeakPtr<net::QuicChromiumClientSession> const&, net::QuicChromiumClientStream**, base::Callback<void (int), (base::internal::CopyMode)1> const&)+30
05-07 15:26:26.195 F/DEBUG   (  190):     #02 pc libcronet.so: 00102b70: net::QuicHttpStream::DoStreamRequest()+56
05-07 15:26:26.195 F/DEBUG   (  190):     #03 pc libcronet.so: 00103652: net::QuicHttpStream::DoLoop(int)+82
05-07 15:26:26.196 F/DEBUG   (  190):     #04 pc libcronet.so: 00103cbc: net::QuicHttpStream::OnIOComplete(int)+4
05-07 15:26:26.196 F/DEBUG   (  190):     #05 pc libcronet.so: 0008750e: base::internal::Invoker<base::IndexSequence<0u>, base::internal::BindState<base::internal::RunnableAdapter<void (net::QuicHttpStream::*)(int)>, void (net::QuicHttpStream*, int), base::WeakPtr<net::QuicHttpStream> >, base::internal::InvokeHelper<true, void, base::internal::RunnableAdapter<void (net::QuicHttpStream::*)(int)> >, void (int)>::Run(base::internal::BindStateBase*, int&&)+84
05-07 15:26:26.196 F/DEBUG   (  190):     #06 pc libcronet.so: 000a419e: net::UploadDataStream::OnReadCompleted(int)+74
05-07 15:26:26.196 F/DEBUG   (  190):     #07 pc libcronet.so: 0001baa2: base::internal::Invoker<base::IndexSequence<0u, 1u, 2u>, base::internal::BindState<base::internal::RunnableAdapter<void (cronet::CronetUploadDataStream::*)(int, bool)>, void (cronet::CronetUploadDataStream*, int, bool), base::WeakPtr<cronet::CronetUploadDataStream>&, int&, bool&>, base::internal::InvokeHelper<true, void, base::internal::RunnableAdapter<void (cronet::CronetUploadDataStream::*)(int, bool)> >, void ()>::Run(base::internal::BindStateBase*)+74
05-07 15:26:26.196 F/DEBUG   (  190):     #08 pc libcronet.so: 0002c890: base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&)+112
05-07 15:26:26.196 F/DEBUG   (  190):     #09 pc libcronet.so: 00038dbc: base::MessageLoop::RunTask(base::PendingTask const&)+92
05-07 15:26:26.196 F/DEBUG   (  190):     #10 pc libcronet.so: 00039202: base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&)+130
05-07 15:26:26.196 F/DEBUG   (  190):     #11 pc libcronet.so: 00039494: base::MessageLoop::DoWork()+132
05-07 15:26:26.196 F/DEBUG   (  190):     #12 pc libcronet.so: 00022b20: base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)+112
05-07 15:26:26.197 F/DEBUG   (  190):     #13 pc libcronet.so: 000416c0: base::RunLoop::Run()+56
05-07 15:26:26.197 F/DEBUG   (  190):     #14 pc libcronet.so: 0003892c: base::MessageLoop::Run()+12
05-07 15:26:26.197 F/DEBUG   (  190):     #15 pc libcronet.so: 0004cc98: base::Thread::ThreadMain()+184
05-07 15:26:26.197 F/DEBUG   (  190):     #16 pc libcronet.so: 0004ab8a: base::(anonymous namespace)::ThreadFunc(void*)+50
05-07 15:26:26.197 F/DEBUG   (  190):     #17 pc 0003f45f  /system/lib/libc.so (__pthread_start(void*)+30)
05-07 15:26:26.197 F/DEBUG   (  190):     #18 pc 00019b43  /system/lib/libc.so (__start_thread+6)

 
Owner: rch@chromium.org
Status: Assigned (was: Untriaged)
Owner: rtenneti@chromium.org
Checked in a temporary fix and check for nullptr to see if it fixes the problem or not. The following is the CL:

https://codereview.chromium.org/2044923003/

Comment 3 by sidv@chromium.org, Jun 13 2016

Labels: M-53
This is affecting GSA. Not i
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b30853b5857eb16dbbaa2560c04746b8d6f02e6

commit 9b30853b5857eb16dbbaa2560c04746b8d6f02e6
Author: rtenneti <rtenneti@chromium.org>
Date: Mon Jun 20 21:37:47 2016

QUIC - Added a histogram to track number of times session_ is null when
QuicHttpStream::DoStreamRequest() is called. This crash was happening in
cronet (b/28676259).

Would like to remove the temporary fix if this crash doesn't happen.

Histogram name: Net.QuicHttpStream::DoStreamRequest.NullSession

BUG= 616812 
R=rkaplow@chromium.org, rch@chromium.org

Review-Url: https://codereview.chromium.org/2073323003
Cr-Commit-Position: refs/heads/master@{#400792}

[modify] https://crrev.com/9b30853b5857eb16dbbaa2560c04746b8d6f02e6/net/quic/quic_http_stream.cc
[modify] https://crrev.com/9b30853b5857eb16dbbaa2560c04746b8d6f02e6/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by sheriffbot@chromium.org, Jul 7 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by sidv@chromium.org, Jul 18 2016

Status: Fixed (was: Assigned)
Marking this as FIXED based on the internal bug (which was marked fixed)
So far in UMA for the last 28 days in chromium, there are no entries for the following histogram on any platforms.

Is it possible to see if we are getting any data for cronet? thanks.

Net.QuicHttpStream::DoStreamRequest.NullSession 

Sign in to add a comment