New issue
Advanced search Search tips

Issue 616807 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 614115



Sign in to add a comment

Add metrics to know how often WebAudio starts without a user gesture

Project Member Reported by mlamouri@chromium.org, Jun 2 2016

Issue description

This would be especially useful on mobile where we expect most websites to require a user gesture for Web Audio because of Safari iOS limitations. Having this data in hand will help us make a decision.
 
Blocking: 614115
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 3 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-53 -MovedFrom-52 Merge-Request-52 M-52
Status: Started (was: Assigned)
Requesting merge to 52 so we can have early stats.

Comment 5 by tin...@google.com, Jun 7 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 7 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbcce37a04df2f0ca1b103827975d7b061e718bb

commit cbcce37a04df2f0ca1b103827975d7b061e718bb
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Jun 07 19:40:22 2016

WebAudio: record whether user gesture was available and provided.

We are looking into a more consistent audio playback on mobile and want
to see whether implementing Safari iOS behaviour in Chrome Android would
break websites.

BUG= 616807 

Review-Url: https://codereview.chromium.org/2031393003
Cr-Commit-Position: refs/heads/master@{#398061}
(cherry picked from commit 9eeee90e6f8d52fce0b3645f933796abc13fe891)

Review URL: https://codereview.chromium.org/2046933003 .

Cr-Commit-Position: refs/branch-heads/2743@{#266}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h
[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp
[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp
[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbcce37a04df2f0ca1b103827975d7b061e718bb

commit cbcce37a04df2f0ca1b103827975d7b061e718bb
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Jun 07 19:40:22 2016

WebAudio: record whether user gesture was available and provided.

We are looking into a more consistent audio playback on mobile and want
to see whether implementing Safari iOS behaviour in Chrome Android would
break websites.

BUG= 616807 

Review-Url: https://codereview.chromium.org/2031393003
Cr-Commit-Position: refs/heads/master@{#398061}
(cherry picked from commit 9eeee90e6f8d52fce0b3645f933796abc13fe891)

Review URL: https://codereview.chromium.org/2046933003 .

Cr-Commit-Position: refs/branch-heads/2743@{#266}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h
[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp
[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp
[modify] https://crrev.com/cbcce37a04df2f0ca1b103827975d7b061e718bb/tools/metrics/histograms/histograms.xml

Sign in to add a comment