New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616801 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Don't include deprecated or future policies in app restrictions schema XML

Project Member Reported by bauerb@chromium.org, Jun 2 2016

Issue description

We shouldn't include deprecated or future policies in the automatically generated app restrictions schema XML, to discourage their use (and prevent confusion).
 
Cc: k...@chromium.org
Labels: Enterprise-triaged

Comment 3 by bauerb@chromium.org, Nov 24 2016

Cc: aber...@chromium.org
Labels: -Enterprise-triaged Enterprise-Triaged
Owner: aber...@chromium.org
Status: Assigned (was: Available)

Comment 5 by k...@chromium.org, Nov 28 2016

Adding my original rationale for the record, I overrode IsDeprecatedPolicySupported and IsFuturePolicySupported as I thought it made sense to expose them until they are deleted or for testing new policies using the policy management tools.
Makes sense to remove them if confusing.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d9428bb6b7d6a77e1d68f26d5dad81b224148d5

commit 0d9428bb6b7d6a77e1d68f26d5dad81b224148d5
Author: aberent <aberent@chromium.org>
Date: Tue Nov 29 10:31:10 2016

[Android app restrictions] Hide unused and improve descriptions.

Remove future and deprecated policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG= 616800 
BUG= 616801 

Review-Url: https://codereview.chromium.org/2529383003
Cr-Commit-Position: refs/heads/master@{#434949}

[modify] https://crrev.com/0d9428bb6b7d6a77e1d68f26d5dad81b224148d5/components/policy/tools/generate_policy_source.py
[modify] https://crrev.com/0d9428bb6b7d6a77e1d68f26d5dad81b224148d5/tools/grit/grit/format/policy_templates/writers/android_policy_writer.py
[modify] https://crrev.com/0d9428bb6b7d6a77e1d68f26d5dad81b224148d5/tools/grit/grit/format/policy_templates/writers/android_policy_writer_unittest.py

Status: Fixed (was: Assigned)

Sign in to add a comment