New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616776 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

update servo label detection to consider moblab use case.

Project Member Reported by kevcheng@chromium.org, Jun 2 2016

Issue description

servos on moblabs are detected differently (using host attributes).  Update ServoLabel's exists() method to take that into consideration.

moblab logic:
https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/server/hosts/servo_host.py?rcl=1f870a399949682df7440081b1043df1b4a93935&l=784
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bbe5cf1f0414dadc167763eef09139995f5cc634

commit bbe5cf1f0414dadc167763eef09139995f5cc634
Author: Kevin Cheng <kevcheng@chromium.org>
Date: Thu Jun 09 04:50:01 2016

[autotest] Update servo label exists method.

The current label detection mechanism just tries to ping the transformed
dut hostname into a servo host hostname.  The servo host hostname can
also be gathered from the host attributes as well so try that first.

BUG= chromium:616776 
TEST=locally on moblab

Change-Id: I50596f0f3e0b3d7344bc12f8f38bfbe7fe8bf304
Reviewed-on: https://chromium-review.googlesource.com/351014
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>

[modify] https://crrev.com/bbe5cf1f0414dadc167763eef09139995f5cc634/server/hosts/cros_label.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bbe5cf1f0414dadc167763eef09139995f5cc634

commit bbe5cf1f0414dadc167763eef09139995f5cc634
Author: Kevin Cheng <kevcheng@chromium.org>
Date: Thu Jun 09 04:50:01 2016

[autotest] Update servo label exists method.

The current label detection mechanism just tries to ping the transformed
dut hostname into a servo host hostname.  The servo host hostname can
also be gathered from the host attributes as well so try that first.

BUG= chromium:616776 
TEST=locally on moblab

Change-Id: I50596f0f3e0b3d7344bc12f8f38bfbe7fe8bf304
Reviewed-on: https://chromium-review.googlesource.com/351014
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>

[modify] https://crrev.com/bbe5cf1f0414dadc167763eef09139995f5cc634/server/hosts/cros_label.py

Status: Fixed (was: Untriaged)

Sign in to add a comment