New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616768 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 622387
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
Team-Accessibility

Blocking:
issue 616699



Sign in to add a comment

"accessibility/image-inside-link.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 2 2016

Issue description

"accessibility/image-inside-link.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRhY2Nlc3NpYmlsaXR5L2ltYWdlLWluc2lkZS1saW5rLmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: dmazz...@chromium.org
Components: UI>Accessibility
Labels: -Sheriff-Chromium OS-All
Owner: nek...@chromium.org
Status: Assigned (was: Untriaged)
Revert has landed; please make the test non-flaky before relanding.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d86069ee9b4f00d97d5658f3fd2a9b3842b15bb9

commit d86069ee9b4f00d97d5658f3fd2a9b3842b15bb9
Author: jbroman <jbroman@chromium.org>
Date: Thu Jun 02 15:36:13 2016

Revert of Make click targets inside links work. (patchset #4 id:60001 of https://codereview.chromium.org/2021953002/ )

Reason for revert:
Flakily timing out:
https://bugs.chromium.org/p/chromium/issues/detail?id=616768

Original issue's description:
> Make click targets inside links work.
>
> There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
> For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
> BUG= 615904 
> R=dmazzoni@chromium.org
>
> Committed: https://crrev.com/d4cff44e1023869434c07689e29ee4440a3b7a2e
> Cr-Commit-Position: refs/heads/master@{#397211}

TBR=dmazzoni@chromium.org,nektar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 615904 , 616768 

Review-Url: https://codereview.chromium.org/2035583003
Cr-Commit-Position: refs/heads/master@{#397416}

[delete] https://crrev.com/82a7b410387ac390eb1cae7b96fa7b19849448eb/third_party/WebKit/LayoutTests/accessibility/image-inside-link.html
[modify] https://crrev.com/d86069ee9b4f00d97d5658f3fd2a9b3842b15bb9/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Blocking: 616699
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a9efc33eff42eb20660bde7a878c2eec6afc610

commit 8a9efc33eff42eb20660bde7a878c2eec6afc610
Author: jbroman <jbroman@chromium.org>
Date: Thu Jun 02 16:00:10 2016

Revert of Disable accessibility/image-inside-link.html on Mac (patchset #1 id:1 of https://codereview.chromium.org/2028383004/ )

Reason for revert:
I reverted the test altogether for flakiness, but this line was left behind.

https://bugs.chromium.org/p/chromium/issues/detail?id=616768

Original issue's description:
> Disable accessibility/image-inside-link.html on Mac
>
> TBR=wangxianzhu@chromium.org
> BUG= 616699 
>
> Committed: https://crrev.com/3c31fcd4ee220ea042f269b5214403fb98357f76
> Cr-Commit-Position: refs/heads/master@{#397345}

TBR=wangxianzhu@chromium.org,vabr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 616699 , 616768 

Review-Url: https://codereview.chromium.org/2033703003
Cr-Commit-Position: refs/heads/master@{#397427}

[modify] https://crrev.com/8a9efc33eff42eb20660bde7a878c2eec6afc610/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by nek...@chromium.org, Nov 14 2016

Cc: ellyjo...@chromium.org nek...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Labels: NewComponent-Accessibility-Internals NewComponent-Accessibility
Components: Internals>Accessibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-internals -newcomponent-accessibility
Labels: triage-dtseng
Mergedinto: 622387
Status: Duplicate (was: Available)

Sign in to add a comment