New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 616761 link

Starred by 3 users
Status: Verified
Owner:
█ avayvod@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
mlamouri@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
tguilbert@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

V8 side of HTMLMediaElement.remote gets gc-ed

Project Member Reported by avayvod@chromium.org, Jun 2 2016 
1. Enable experimental web platform features in Chrome on Android.
2. Open avayvod.github.io/remote-playback-test.html
3. Click "Play remotely", select a Cast device.
4. Disconnect from the notification, Cast button or wait until the video finishes.

ER: the state of the page goes back to local playback mode
AR: the state doesn't change more often than not

The event is not fired to the page as V8 believes the RemotePlayback script wrapper can be garbage collected.
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 3 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10633dff101889d287c524266420f3b37dc7a23c

commit 10633dff101889d287c524266420f3b37dc7a23c
Author: avayvod <avayvod@chromium.org>
Date: Mon Jun 06 12:52:56 2016

[Android, RemotePlayback] Make RemotePlayback classes ActiveScriptWrappable's

Keeps the V8 wrappers alive as long as there're event listeners or pending
promises and such.

BUG= 616761 
TEST=manual, see repro steps in the bug

Review-Url: https://codereview.chromium.org/2038573002
Cr-Commit-Position: refs/heads/master@{#398014}

[modify] https://crrev.com/10633dff101889d287c524266420f3b37dc7a23c/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/10633dff101889d287c524266420f3b37dc7a23c/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
[modify] https://crrev.com/10633dff101889d287c524266420f3b37dc7a23c/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.idl
[modify] https://crrev.com/10633dff101889d287c524266420f3b37dc7a23c/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp
[modify] https://crrev.com/10633dff101889d287c524266420f3b37dc7a23c/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.h
[modify] https://crrev.com/10633dff101889d287c524266420f3b37dc7a23c/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.idl

Comment 3 by avayvod@chromium.org, Jun 6 2016

Labels: -MovedFrom-52 Merge-Request-52 M-52

Comment 4 by tin...@google.com, Jun 6 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ac36391ca6c027b717c25f17026d3e9b9a9f3cd

commit 1ac36391ca6c027b717c25f17026d3e9b9a9f3cd
Author: Anton Vayvod <avayvod@google.com>
Date: Mon Jun 06 13:24:05 2016

[Android, RemotePlayback] Make RemotePlayback classes ActiveScriptWrappable's

Keeps the V8 wrappers alive as long as there're event listeners or pending
promises and such.

BUG= 616761 
TEST=manual, see repro steps in the bug

Review-Url: https://codereview.chromium.org/2038573002
Cr-Commit-Position: refs/heads/master@{#398014}
(cherry picked from commit 10633dff101889d287c524266420f3b37dc7a23c)

Review URL: https://codereview.chromium.org/2043703002 .

Cr-Commit-Position: refs/branch-heads/2743@{#234}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/1ac36391ca6c027b717c25f17026d3e9b9a9f3cd/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/1ac36391ca6c027b717c25f17026d3e9b9a9f3cd/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
[modify] https://crrev.com/1ac36391ca6c027b717c25f17026d3e9b9a9f3cd/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.idl
[modify] https://crrev.com/1ac36391ca6c027b717c25f17026d3e9b9a9f3cd/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp
[modify] https://crrev.com/1ac36391ca6c027b717c25f17026d3e9b9a9f3cd/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.h
[modify] https://crrev.com/1ac36391ca6c027b717c25f17026d3e9b9a9f3cd/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.idl

Comment 6 by avayvod@chromium.org, Jun 7 2016

Status: Fixed (was: Started)

Comment 7 by ram...@chromium.org, Jun 7 2016

Status: Verified (was: Fixed)
Verified with latest Chrome Dev '52.0.2743.32'
►

Sign in to add a comment