New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616756 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature
SSO



Sign in to add a comment

Change timeout for SAML webview with camera capture

Project Member Reported by emaxx@chromium.org, Jun 2 2016

Issue description

Currently, the hard timeout for the SAML flow having an active camera capture is 180 seconds (see  bug 606979 ).

The timeout has to be decreased to 90 seconds.
 

Comment 1 by emaxx@chromium.org, Jun 2 2016

David, could you please confirm the 90 second timeout?
Cc: scottgerwin@google.com
Labels: -Pri-2 Pri-1
Apologies got caught up and couldn't open the bug myself. Confirming that 90 seconds is what we want for the timeout. +product counsel as FYI.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bde2dd5a2bc77e83cf1bb0447d2980d9edec495d

commit bde2dd5a2bc77e83cf1bb0447d2980d9edec495d
Author: emaxx <emaxx@chromium.org>
Date: Thu Jun 02 23:35:23 2016

Decrease SAML webview with camera timeout to 90 seconds

The hard timeout for the SAML flow having an active camera capture is
now 90 seconds.

BUG= 616756 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2033113002
Cr-Commit-Position: refs/heads/master@{#397544}

[modify] https://crrev.com/bde2dd5a2bc77e83cf1bb0447d2980d9edec495d/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Project Member

Comment 4 by sheriffbot@chromium.org, Jun 3 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by emaxx@chromium.org, Jun 10 2016

Labels: -M-53 -MovedFrom-52 Merge-Request-52 M-52
Status: Fixed (was: Started)
Requesting merge to 52, as this change sets the desired timeout for the functionality introduced in  issue 606979  (which already went into 52).

The change here is pretty straightforward: it's just halving the hardcoded timeout interval.

Comment 6 by tin...@google.com, Jun 10 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 10 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64e22a9c4ef7359917538575364591ddf4513052

commit 64e22a9c4ef7359917538575364591ddf4513052
Author: Maksim Ivanov <emaxx@chromium.org>
Date: Fri Jun 10 00:50:09 2016

Decrease SAML webview with camera timeout to 90 seconds

The hard timeout for the SAML flow having an active camera capture is
now 90 seconds.

BUG= 616756 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2033113002
Cr-Commit-Position: refs/heads/master@{#397544}
(cherry picked from commit bde2dd5a2bc77e83cf1bb0447d2980d9edec495d)

Review URL: https://codereview.chromium.org/2057893002 .

Cr-Commit-Position: refs/branch-heads/2743@{#306}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/64e22a9c4ef7359917538575364591ddf4513052/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Cc: krishna...@chromium.org
Labels: SSO
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64e22a9c4ef7359917538575364591ddf4513052

commit 64e22a9c4ef7359917538575364591ddf4513052
Author: Maksim Ivanov <emaxx@chromium.org>
Date: Fri Jun 10 00:50:09 2016

Decrease SAML webview with camera timeout to 90 seconds

The hard timeout for the SAML flow having an active camera capture is
now 90 seconds.

BUG= 616756 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2033113002
Cr-Commit-Position: refs/heads/master@{#397544}
(cherry picked from commit bde2dd5a2bc77e83cf1bb0447d2980d9edec495d)

Review URL: https://codereview.chromium.org/2057893002 .

Cr-Commit-Position: refs/branch-heads/2743@{#306}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/64e22a9c4ef7359917538575364591ddf4513052/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Status: Verified (was: Fixed)
Verified on R52.0.2743.43;8350.33 that the camera timeout is now 90s. 

Sign in to add a comment