Change timeout for SAML webview with camera capture |
||||||||
Issue descriptionCurrently, the hard timeout for the SAML flow having an active camera capture is 180 seconds (see bug 606979 ). The timeout has to be decreased to 90 seconds.
,
Jun 2 2016
Apologies got caught up and couldn't open the bug myself. Confirming that 90 seconds is what we want for the timeout. +product counsel as FYI.
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bde2dd5a2bc77e83cf1bb0447d2980d9edec495d commit bde2dd5a2bc77e83cf1bb0447d2980d9edec495d Author: emaxx <emaxx@chromium.org> Date: Thu Jun 02 23:35:23 2016 Decrease SAML webview with camera timeout to 90 seconds The hard timeout for the SAML flow having an active camera capture is now 90 seconds. BUG= 616756 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2033113002 Cr-Commit-Position: refs/heads/master@{#397544} [modify] https://crrev.com/bde2dd5a2bc77e83cf1bb0447d2980d9edec495d/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
,
Jun 3 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 10 2016
Requesting merge to 52, as this change sets the desired timeout for the functionality introduced in issue 606979 (which already went into 52). The change here is pretty straightforward: it's just halving the hardcoded timeout interval.
,
Jun 10 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64e22a9c4ef7359917538575364591ddf4513052 commit 64e22a9c4ef7359917538575364591ddf4513052 Author: Maksim Ivanov <emaxx@chromium.org> Date: Fri Jun 10 00:50:09 2016 Decrease SAML webview with camera timeout to 90 seconds The hard timeout for the SAML flow having an active camera capture is now 90 seconds. BUG= 616756 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2033113002 Cr-Commit-Position: refs/heads/master@{#397544} (cherry picked from commit bde2dd5a2bc77e83cf1bb0447d2980d9edec495d) Review URL: https://codereview.chromium.org/2057893002 . Cr-Commit-Position: refs/branch-heads/2743@{#306} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/64e22a9c4ef7359917538575364591ddf4513052/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
,
Jun 12 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64e22a9c4ef7359917538575364591ddf4513052 commit 64e22a9c4ef7359917538575364591ddf4513052 Author: Maksim Ivanov <emaxx@chromium.org> Date: Fri Jun 10 00:50:09 2016 Decrease SAML webview with camera timeout to 90 seconds The hard timeout for the SAML flow having an active camera capture is now 90 seconds. BUG= 616756 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2033113002 Cr-Commit-Position: refs/heads/master@{#397544} (cherry picked from commit bde2dd5a2bc77e83cf1bb0447d2980d9edec495d) Review URL: https://codereview.chromium.org/2057893002 . Cr-Commit-Position: refs/branch-heads/2743@{#306} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/64e22a9c4ef7359917538575364591ddf4513052/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
,
Jun 20 2016
Verified on R52.0.2743.43;8350.33 that the camera timeout is now 90s. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by emaxx@chromium.org
, Jun 2 2016