Regression : 'Clear Search' (x) button appears after a delay while performing 'Search' action in chrome://history.
Reported by
yfulgaon...@etouch.net,
Jun 2 2016
|
||||||
Issue descriptionChrome version : 53.0.2754.0 (Official Build) ab317e073bd7b2cb74c405f23008d0a6d4db6270-refs/heads/master@{#397000} 32/64 bit OS : Windows (7,8,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS) Pre-condition : Please enable ‘Material Design history’ flag from chrome://flags. What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://history. 2. Click on search field, type something and observe the 'Clear Search' button. Actual : 'Clear Search' (x) button appears after a delay while performing 'Search' action in chrome://history. Expected : 'Clear Search' (X) button should appear immediately in chrome://history. This is a regression issue, broken in 'M-53', below is the Manual Bisect and Narrow Bisect info. Good Build : 53.0.2749.0 Bad Build : 53.0.2750.0 Narrow Bisect : https://chromium.googlesource.com/chromium/src/+log/3d392de68c541604a01a0c077c44d0ba4c7a02c7..d9a96896948d55fb51b919566f7a6c5ec1fd4980?pretty=fuller&n=10000 Suspecting : r396115 from Narrow Bisect
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b28158033e882c541f6ff3dc0111b94f59a2ed0 commit 7b28158033e882c541f6ff3dc0111b94f59a2ed0 Author: tsergeant <tsergeant@chromium.org> Date: Thu Jun 23 02:54:00 2016 MD Search Field: Properly respond to external changes to search value. Ensures that when the search value is changed by something other than direct typing the search field will still open correctly. This fixes issues with dragging or pasting text into the input field. BUG= 616740 , 618633 , 622074 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2090513002 Cr-Commit-Position: refs/heads/master@{#401527} [modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js [modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js [modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html [modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js
,
Jun 23 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tsergeant@chromium.org
, Jun 17 2016