New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 616732 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Jun 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Red highlight on invalid inputs is not seen properly.

Reported by rk...@etouch.net, Jun 2 2016 
Chrome Version:53.0.2754.0 Revision ab317e073bd7b2cb74c405f23008d0a6d4db6270-refs/heads/master@{#397000} 
OS:Mac (10.10.5 , 10.11.4),Mac Retina (10.11.4)

What steps will reproduce the problem?
(1) Launch chrome, open dev tools window and navigate to 'Network Conditions' section.
(2) Uncheck the checkbox of 'User agent' and observe the highlight on custom UA string.

Red highlight on custom UA string is not seen properly.

Red highlight on custom UA string should be seen properly.

This is a regression issue, broken in 'M-53', below is bisect info:

Good Build: 53.0.2753.0
Bad Build: 53.0.2754.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/122369ab8e771215d1afca236a20d16002c5000b..c11f4fa6d44be764cf167084cad1a2762f8e7cbf?pretty=fuller&n=100

Suspecting: r396878

Note: Issue is not seen on Windows and Linux OS.
Actual_Devtools.mov
2.8 MB Download
Expected_Windows.mp4
543 KB Download

Comment 1 by l...@chromium.org, Jun 2 2016

Summary: Regression: Red highlight on invalid inputs is not seen properly. (was: Regression: Red highlight on custom UA string is not seen properly.)
Good find.  This also appears on several other inputs within DevTools, including in the Sensors Drawer and Devices Settings tab.
Screen Shot 2016-06-02 at 10.43.31 AM.png
85.6 KB View Download
Screen Shot 2016-06-02 at 10.43.42 AM.png
56.0 KB View Download

Comment 2 by l...@chromium.org, Jun 2 2016

Status: Started (was: Assigned)
CL in review
https://codereview.chromium.org/2033093004/
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de4a6e8d6d598c76b84e6aa85dfb82b55b3d6ae8

commit de4a6e8d6d598c76b84e6aa85dfb82b55b3d6ae8
Author: luoe <luoe@chromium.org>
Date: Mon Jun 20 21:39:31 2016

DevTools: fix invalid outline style across inputs

This makes the custom UA input use the same error highlighting style
as other inputs in DevTools, and fixes the outline offset present when
using OS X.

BUG= 616732 

Review-Url: https://codereview.chromium.org/2033093004
Cr-Commit-Position: refs/heads/master@{#400793}

[modify] https://crrev.com/de4a6e8d6d598c76b84e6aa85dfb82b55b3d6ae8/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
[modify] https://crrev.com/de4a6e8d6d598c76b84e6aa85dfb82b55b3d6ae8/third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css
[modify] https://crrev.com/de4a6e8d6d598c76b84e6aa85dfb82b55b3d6ae8/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css

Comment 4 by l...@chromium.org, Jun 22 2016

Status: Fixed (was: Started)
►

Sign in to add a comment