New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616730 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

FormAutofillTest.WebFormElementToFormDataTooManyFields failing on Mac and CrOS ASAN bots

Project Member Reported by vabr@chromium.org, Jun 2 2016

Issue description

Links to builds (Mac stdio attached, the CrOS was too big):
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/16936
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/13232

Sample output:
FormAutofillTest.WebFormElementToFormDataTooManyFields (run #1):
[ RUN      ] FormAutofillTest.WebFormElementToFormDataTooManyFields
../../content/public/test/render_view_test.cc:427: Failure
Value of: result.numberOfLiveDocuments
  Actual: 1
Expected: 0u
Which is: 0
../../content/public/test/render_view_test.cc:428: Failure
Value of: result.numberOfLiveNodes
  Actual: 608
Expected: 0u
Which is: 0
../../content/public/test/render_view_test.cc:431: Failure
Value of: result.numberOfLiveActiveDOMObjects
  Actual: 1
Expected: 0u
Which is: 0
[  FAILED  ] FormAutofillTest.WebFormElementToFormDataTooManyFields (491 ms)

findit-for-me.appspot.com reported https://codereview.chromium.org/2029843002 as a culprit for CrOS, so will try to revert that speculatively.
 
Mac Log File contents.html
3.3 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d4d2467316e320d44d59db7113d6474549bf617

commit 8d4d2467316e320d44d59db7113d6474549bf617
Author: vabr <vabr@chromium.org>
Date: Thu Jun 02 11:53:43 2016

Revert of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2029843002/ )

Reason for revert:
Speculative revert, may have broken FormAutofillTest.WebFormElementToFormDataTooManyFields on ASAN bots.
For more info see:
BUG=616730

Original issue's description:
> Stopped WebVR from being partially enabled during testing.
>
> Should prevent repeated instances of "blink::mojom::VRService not found" in test
> logs.
>
> BUG= 614752 
>
> Committed: https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a
> Cr-Commit-Position: refs/heads/master@{#397335}

TBR=esprehn@chromium.org,bajones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 614752 

Review-Url: https://codereview.chromium.org/2030913002
Cr-Commit-Position: refs/heads/master@{#397372}

[modify] https://crrev.com/8d4d2467316e320d44d59db7113d6474549bf617/content/child/runtime_features.cc
[modify] https://crrev.com/8d4d2467316e320d44d59db7113d6474549bf617/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 2 by vabr@chromium.org, Jun 2 2016

Actually, the test seems rather flaky, it had 4 green builds on the mac bot before the revert landed. Given that I don't see how the reverted CL could have caused the test to fail, I'll reland it and disable the test instead.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afc1a78a173991463b44ea98822994f80075b1c5

commit afc1a78a173991463b44ea98822994f80075b1c5
Author: vabr <vabr@chromium.org>
Date: Thu Jun 02 11:58:42 2016

Reland of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2030913002/ )

Reason for revert:
This revert was speculative and the test proved to be too flaky for the revert results to be conclusive.

Sorry for the noise, relanding.

Original issue's description:
> Revert of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2029843002/ )
>
> Reason for revert:
> Speculative revert, may have broken FormAutofillTest.WebFormElementToFormDataTooManyFields on ASAN bots.
> For more info see:
> BUG=616730
>
> Original issue's description:
> > Stopped WebVR from being partially enabled during testing.
> >
> > Should prevent repeated instances of "blink::mojom::VRService not found" in test
> > logs.
> >
> > BUG= 614752 
> >
> > Committed: https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a
> > Cr-Commit-Position: refs/heads/master@{#397335}
>
> TBR=esprehn@chromium.org,bajones@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 614752 
>
> Committed: https://crrev.com/8d4d2467316e320d44d59db7113d6474549bf617
> Cr-Commit-Position: refs/heads/master@{#397372}

TBR=esprehn@chromium.org,bajones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616730

Review-Url: https://codereview.chromium.org/2030023002
Cr-Commit-Position: refs/heads/master@{#397373}

[modify] https://crrev.com/afc1a78a173991463b44ea98822994f80075b1c5/content/child/runtime_features.cc
[modify] https://crrev.com/afc1a78a173991463b44ea98822994f80075b1c5/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 4 by vabr@chromium.org, Jun 2 2016

Cc: -bajones@chromium.org
Owner: ----
Status: Available (was: Assigned)
Disabling the test is in https://codereview.chromium.org/2025423004/.
Not sure about the correct priority, so keeping high at the moment. Whoever does triaging for autofill, please feel free to adjust.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30c929f0bef6cf15dcc244602be7496e413d220c

commit 30c929f0bef6cf15dcc244602be7496e413d220c
Author: vabr <vabr@chromium.org>
Date: Thu Jun 02 12:53:11 2016

Disable FormAutofillTest.WebFormElementToFormDataTooManyFields on Mac and CrOS

TBR=mathp@chromium.org
BUG=616730

Review-Url: https://codereview.chromium.org/2025423004
Cr-Commit-Position: refs/heads/master@{#397376}

[modify] https://crrev.com/30c929f0bef6cf15dcc244602be7496e413d220c/chrome/renderer/autofill/form_autofill_browsertest.cc

Project Member

Comment 6 by sheriffbot@chromium.org, Jul 7 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 7 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by tapted@chromium.org, Jul 21 2017

Cc: zkoch@chromium.org
Status: Available (was: Untriaged)
[mac triage] #c4: "Whoever does triaging for autofill, please feel free to adjust."

Comment 9 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Available)

Sign in to add a comment