Issue metadata
Sign in to add a comment
|
Color of "Press Cmd+Left Arrow to go back" pop up is not seen uniform.
Reported by
rk...@etouch.net,
Jun 2 2016
|
||||||||||||||||||||||||
Issue descriptionChrome Version: 53.0.2754.0 Revision ab317e073bd7b2cb74c405f23008d0a6d4db6270-refs/heads/master@{#397000} OS: Mac Retina (10.11.4) What steps will reproduce the problem? (1) Launch chrome, navigate to https://plus.google.com/collection/s0zdP (2) Press 'Backspace' and observe the color of pop up. Color of "Press Alt+Left Arrow to go back" pop up is not seen uniform. Color of "Press Alt+Left Arrow to go back" pop up should be seen properly. This is a non-regression issue,as this is new feature introduced in 'M-53' ChangeLog info: https://chromium.googlesource.com/chromium/src/+log/53.0.2753.0..53.0.2754.0?pretty=fuller&n=10000 Suspecting: r396759 Note: Issue is not seen on Windows, Linux and Macpro(10.11.4, 10.10.5)
,
Jun 3 2016
Please attach a screenshot. On the Mac this alert looks fine, and it's Cmd-Left Arrow, not Alt - I'm wondering if you're using some platform other than the Mac?
,
Jun 6 2016
From the video, this is Issue 604092 . We couldn't reproduce it; any further advice on reproducing would be appreciated.
,
Jun 6 2016
#2 The video shows that it is Mac, and it is Cmd (not Alt). Wonder why the report says Alt everywhere. Turns out we can reproduce it (that other bug was a little out of date). It only happens on Mac retina displays.
,
Jun 20 2016
Verified the fix for this in 53.0.2773.0 Canary. Requesting merge of r400273 to M-52 which is where "Press ⌘+← to go back" is launching (see Issue 610039 ). Description (duplicated from https://codereview.chromium.org/2065003002/) is Do not SchedulePaint() inside views::Label::OnPaint() View::SchedulePaint() shouldn't be called inside an OnPaint() method. At best it wastes computation doing a follow-up, redundant paint. On Mac it's causing a weird interaction with transparent backgrounds for strings of particular lengths on retina screens. For performance, MaybeBuildRenderTextLines() is always deferred until a Paint. It calls RecalculateColors() to apply colors to the lines it newly creates, and that schedules a paint. But MaybeBuildRenderTextLines() just needs to apply the colors that have already been calculated. So, to fix, split RecalculateColors() into the color calculation and ApplyTextColors(), which can be called from OnPaint(). BUG= 604092 TEST=On a retina-screen Mac with a fresh profile, navigate (e.g. to chrome://version), then press Backspace, The "Press <key> to go back" popup should appear and it should have a consistent, transparent background. Committed: https://crrev.com/2b40c5ca82b21f503cc7cc75ac101f1d2b710fc1 Cr-Commit-Position: refs/heads/master@{#400273} ( Issue 604092 is being ignored by the bugdroid scripts for some reason, so requesting here instead).
,
Jun 21 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Jun 2 2016