Regression: 'No search results found' is seen blinking on typing any text in search field.
Reported by
jshan...@etouch.net,
Jun 2 2016
|
||||||||
Issue descriptionChrome Version: 52.0.2743.24 Revision 334afe94883b731af3eacab708ac03ba796d5c5b-refs/branch-heads/2743@{#181}(32/64 bit) OS: Windows(7,8,10), Linux (14.04 LTS),Mac(10.10.5, 10.11.4) Pre-condition: 1. Enable Material Design history from chrome://flags. 2. Create some history by navigating any webpage. Steps: 1. Launch chrome, navigate to chrome://history. 2. Click on Search field and type something like 'aaa' and observe text 'No search results found'. Actual: Text 'No search results found' is seen blinking on typing any text in search field. Expected: Text 'No search results found' should not blink on typing any text in search field. This is a regression issue broken in M-51, below is bisect info. Good build: 51.0.2670.0 Bad build: 51.0.2671.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/711ed960a44b9efe6875c68a6d0b3795c5a742a0..0f1b99def010815efd548304136aa69441161c91?pretty=fuller&n=100 Suspecting: r379504 ? Please help to re-assign if your change is not the cause for this issue.
,
Jun 17 2016
,
Mar 21 2017
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb694aba057b170bf406206c9ae3c5211e6669f1 commit bb694aba057b170bf406206c9ae3c5211e6669f1 Author: tsergeant <tsergeant@chromium.org> Date: Tue Mar 21 22:41:35 2017 MD History: Prevent flickering of 'no search results' message The 'no search results' message tries to hide itself whenever a backend query is in progress. This no longer has any useful effect (as the message is already hidden elsewhere), and just causes flickering of the message while typing a search query which has no results. This CL removes this redundant logic, fixing the flickering effect. BUG= 616720 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2764803002 Cr-Commit-Position: refs/heads/master@{#458588} [modify] https://crrev.com/bb694aba057b170bf406206c9ae3c5211e6669f1/chrome/browser/resources/md_history/history_list.html [modify] https://crrev.com/bb694aba057b170bf406206c9ae3c5211e6669f1/chrome/browser/resources/md_history/history_list.js
,
Mar 21 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tsergeant@chromium.org
, Jun 3 2016