Some DevToolsAgentTest and RenderViewImplScaleFactorTest fail on Mac & Linux |
|||
Issue descriptionFailing tests: DevToolsAgentTest.DevToolsResumeOnClose DevToolsAgentTest.RuntimeEvaluateRunMicrotasks RenderViewImplScaleFactorTest.ScreenMetricsEmulationWithOriginalDSF1 RenderViewImplScaleFactorTest.ScreenMetricsEmulationWithOriginalDSF2 Builds: https://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/33776 https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/25011 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/29453 Sample log files attached. findit-for-me.appspot.com picked https://codereview.chromium.org/2026993004 as the suspect from the common blame-list.
,
Jun 2 2016
Revert seems to have fixed https://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29, so I keep it in and pass to the author of the reverted CL.
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0206d8c4aa1f5a659169111a722d183fc2e7739 commit b0206d8c4aa1f5a659169111a722d183fc2e7739 Author: sigbjornf <sigbjornf@opera.com> Date: Thu Jun 02 15:09:20 2016 Delay leak reporting until worker in-process proxies have been finalized. If a document creates a number of workers, terminating these and having their destruction ripple all the way back to the in-process proxy objects isn't immediate. But something that needs to complete before the leak detector can initiate reporting -- an in-process proxy object maintains a strong reference to the document, and would generate a leak if not destructed and its garbage having been collected afterwards. Address the reliability of multi worker shutdown by maintaining a counter of how many in-process proxy objects are still alive and run GCs until it drops to zero. Do that at most two times around. R=haraken,kouhei BUG= 589802 , 616714 Review-Url: https://codereview.chromium.org/2026993004 Cr-Commit-Position: refs/heads/master@{#397405} [modify] https://crrev.com/b0206d8c4aa1f5a659169111a722d183fc2e7739/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp [modify] https://crrev.com/b0206d8c4aa1f5a659169111a722d183fc2e7739/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h [modify] https://crrev.com/b0206d8c4aa1f5a659169111a722d183fc2e7739/third_party/WebKit/Source/web/WebLeakDetector.cpp
,
Jun 2 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 2 2016