New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616714 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Some DevToolsAgentTest and RenderViewImplScaleFactorTest fail on Mac & Linux

Project Member Reported by vabr@chromium.org, Jun 2 2016

Issue description

Failing tests:

DevToolsAgentTest.DevToolsResumeOnClose
DevToolsAgentTest.RuntimeEvaluateRunMicrotasks
RenderViewImplScaleFactorTest.ScreenMetricsEmulationWithOriginalDSF1
RenderViewImplScaleFactorTest.ScreenMetricsEmulationWithOriginalDSF2

Builds:
https://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/33776
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/25011
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/29453

Sample log files attached.

findit-for-me.appspot.com picked https://codereview.chromium.org/2026993004 as the suspect from the common blame-list.
 
MAC Log File contents.html
164 KB View Download
LINUX Log File contents.html
4.8 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16130e2f74c3ccd998d782b16836caf3a7e96f95

commit 16130e2f74c3ccd998d782b16836caf3a7e96f95
Author: vabr <vabr@chromium.org>
Date: Thu Jun 02 10:20:01 2016

Revert of Delay leak reporting until worker in-process proxies have been finalized. (patchset #4 id:60001 of https://codereview.chromium.org/2026993004/ )

Reason for revert:
Speculative revert, seems to have broken some content_browsertests. See the bug:
BUG= 616714 

Original issue's description:
> Delay leak reporting until worker in-process proxies have been finalized.
>
> If a document creates a number of workers, terminating these and having
> their destruction ripple all the way back to the in-process proxy objects
> isn't immediate. But something that needs to complete before the leak
> detector can initiate reporting -- an in-process proxy object maintains a
> strong reference to the document, and would generate a leak if not
> destructed and its garbage having been collected afterwards.
>
> Address the reliability of multi worker shutdown by maintaining a
> counter of how many in-process proxy objects are still alive and run
> GCs until it drops to zero. Do that at most two times around.
>
> For documents not creating any workers, monitoring this proxy count
> avoids having to perform a third GC, something that was conservatively
> done before to address worker shutdown (but not reliably.)
>
> R=haraken,kouhei
> BUG= 589802 
>
> Committed: https://crrev.com/19895c52589f189d6fdc563759c9872af2cbf86c
> Cr-Commit-Position: refs/heads/master@{#397333}

TBR=haraken@chromium.org,kouhei@chromium.org,sigbjornf@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 589802 

Review-Url: https://codereview.chromium.org/2030883003
Cr-Commit-Position: refs/heads/master@{#397355}

[modify] https://crrev.com/16130e2f74c3ccd998d782b16836caf3a7e96f95/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/16130e2f74c3ccd998d782b16836caf3a7e96f95/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/16130e2f74c3ccd998d782b16836caf3a7e96f95/third_party/WebKit/Source/web/WebLeakDetector.cpp

Comment 2 by vabr@chromium.org, Jun 2 2016

Cc: -sigbjo...@opera.com
Owner: sigbjo...@opera.com
Revert seems to have fixed https://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29, so I keep it in and pass to the author of the reverted CL.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0206d8c4aa1f5a659169111a722d183fc2e7739

commit b0206d8c4aa1f5a659169111a722d183fc2e7739
Author: sigbjornf <sigbjornf@opera.com>
Date: Thu Jun 02 15:09:20 2016

Delay leak reporting until worker in-process proxies have been finalized.

If a document creates a number of workers, terminating these and having
their destruction ripple all the way back to the in-process proxy objects
isn't immediate. But something that needs to complete before the leak
detector can initiate reporting -- an in-process proxy object maintains a
strong reference to the document, and would generate a leak if not
destructed and its garbage having been collected afterwards.

Address the reliability of multi worker shutdown by maintaining a
counter of how many in-process proxy objects are still alive and run
GCs until it drops to zero. Do that at most two times around.

R=haraken,kouhei
BUG= 589802 ,  616714 

Review-Url: https://codereview.chromium.org/2026993004
Cr-Commit-Position: refs/heads/master@{#397405}

[modify] https://crrev.com/b0206d8c4aa1f5a659169111a722d183fc2e7739/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/b0206d8c4aa1f5a659169111a722d183fc2e7739/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/b0206d8c4aa1f5a659169111a722d183fc2e7739/third_party/WebKit/Source/web/WebLeakDetector.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment