New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616712 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

chameleon_audio: cleanup USB test

Project Member Reported by cychiang@chromium.org, Jun 2 2016

Issue description

A fail in audio_AudioBasicUSBPlaybackRecord.suspend
https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=306904159

caused the failure on later test: audio_AudioVolume.speaker
https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=306922782

because USB is still plugged.

In the start of the test, we call Reset on chameleond, it unplugs USB on chameleon side. However, on DUT side, it needs to re-enumerate USB to detect that USB is unplugged.

We can do that in usb_facade_native.py in the init of USBFacadeNative.
That way we can make sure USB is re-enumerated again in the start of the test.
 

Comment 1 by ka...@chromium.org, Jun 2 2016

Labels: OS-Chrome
Is it possible to do this at the end of the test too? 
What I am aiming for is all these observations where having USB connection to unplugged solving issues on other following tests.

Comment 2 by ka...@chromium.org, Jun 7 2016

Labels: USBconnect
I found that kernel 4.2 dwc2 driver implements disconnect function correctly. It controls software pull-up on USB port so Cros side can actually see the USB is unplugged. Since we are going to move to kernel 4.2 for bluetooth HID and for suspend/resume issue 618175, this issue will not be a problem anymore.
Also, if kernel 4.2 runs fine, we can clean up usb facade which resets drivers of USB controller on Cros side to re-enumerate USB devices.
Cc: hychao@chromium.org
Status: Started (was: Assigned)
Now that we have deployed kernel 4.2 to chameleon in the lab, it is time to cleanup the usb test.
It will be helpful to do usb plug/unplug stress test.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/52bfcdc9527192e527febe7eef2e2530a0000517

commit 52bfcdc9527192e527febe7eef2e2530a0000517
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Fri Sep 02 08:07:09 2016

[autotest] audio_widget: Remove USBPlugHandler

Since Chameleon with 4.2 kernel supports pull-up resistor control on USB
port, we don't need USBPlugHandler to control USB facade to reset USB
controller or bind/unbind driver.

Remove USBPlugHandler and use DummyPlugHandler for USB widget link.

The USB facade is not removed since it might be useful to control USB
controller in other use cases.

BUG= chromium:616712 
TEST=run audio_AudioBasicUSBPlayback and audio_AudioBasicUSBRecord test
on samus.

Change-Id: I543736017a4b8df75499534e87ac431b914972e1
Reviewed-on: https://chromium-review.googlesource.com/380442
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>

[modify] https://crrev.com/52bfcdc9527192e527febe7eef2e2530a0000517/client/cros/chameleon/audio_widget_link.py
[modify] https://crrev.com/52bfcdc9527192e527febe7eef2e2530a0000517/client/cros/chameleon/audio_widget.py
[modify] https://crrev.com/52bfcdc9527192e527febe7eef2e2530a0000517/client/cros/chameleon/chameleon_audio_helper.py

Comment 6 by kalin@google.com, Oct 20 2016

Status: WontFix (was: Started)
Old issues.

New issues will be filed if tests fail.

Sign in to add a comment