Regression: Hitting spacebar doesn't open the 'Default' drop down list from 'Microphone' access popup.
Reported by
rk...@etouch.net,
Jun 2 2016
|
|||||||||
Issue descriptionChrome Version: 52.0.2743.24 Revision 334afe94883b731af3eacab708ac03ba796d5c5b-refs/branch-heads/2743@{#181}(32/64 bit) OS: Windows(7,8,10), Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, open NTP and click on 'Search by voice' icon(Permission bubble will appear) (2) Click on 'Allow' then click on camera icon present in omnibox. (3) Press 'Tab' key upto focus reaches to 'Default' drop down, then press spacebar and observe. 'Default' drop down list under 'Microphone' does not get opened after pressing 'Spacebar' 'Default' drop down list should gets open after pressing 'Spacebar' This is a regression issue, broken in 'M-52', below is bisect info: Good Build: 52.0.2735.0 Bad Build: 52.0.2738.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/72a5b03ea5b0325e09cd25e9400fb012488776b9..b4ef2f075d3ebf2f948837d213dd875549004eca?pretty=fuller&n=100 Suspecting: r393617 @oshima: Please help me to reassign this issue,if your change is not cause for it. Note: Above issue is not seen on Mac OS.
,
Jun 3 2016
M52 Stable is approaching soon. Please have a fix / revert ASAP.
,
Jun 6 2016
,
Jun 10 2016
this is not a release blocker. I changed it to use a real combobox. The default behavior for comboboxes is not to open on spacebar. I don't know why that is, but it means this is an "improvement". You can use f4 to open it. See https://cs.chromium.org/chromium/src/ui/views/controls/combobox/combobox.cc?rcl=1465571999&l=593 +sky, +ainslie to comment on why spacebar on a normal combobox doesn't open it.
,
Jun 16 2016
Based on comment 4, removing release block label.
,
Jun 16 2016
,
Jun 17 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 20 2016
+hwi and +aboxhall are the keyboard experts so might have ideas about #4.
,
Jun 20 2016
+lpalmaro lpalmaro@, aboxhall@ - as a future improvement, shall we consider adding "spacebar" action to toggle the display of the dropdown menu across platforms? https://www.w3.org/wiki/MenuButton
,
Jul 2 2016
since this is p3, removing milestone
,
Jul 21 2016
,
Aug 5 2016
,
Aug 31 2016
ping hwi, lpalmaro, aboxhall this applies to "Enter" as well as "Space". The only way to open the menu right now is F4 (I for one only knew that by reading the code).
,
Aug 31 2016
Yes, I'm definitely for adding that functionality
,
Aug 31 2016
c13 and c14 SGTM. Thanks!
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f4a390626d934c6473e3023788968b87f8186d9 commit 6f4a390626d934c6473e3023788968b87f8186d9 Author: estade <estade@chromium.org> Date: Thu Sep 01 20:56:49 2016 Activate comboboxes (i.e. open dropdown menu) on Enter and Space. Note that pressing space while the menu is open does nothing. This matches html <select> behavior. Pressing Enter while the menu is open selects the highlighted option and closes the menu. This also matches <select>. BUG= 616685 Review-Url: https://codereview.chromium.org/2299023003 Cr-Commit-Position: refs/heads/master@{#416051} [modify] https://crrev.com/6f4a390626d934c6473e3023788968b87f8186d9/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/6f4a390626d934c6473e3023788968b87f8186d9/ui/views/controls/combobox/combobox_unittest.cc
,
Oct 26 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tkonch...@chromium.org
, Jun 2 2016