New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616683 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Device list in CrOS system tray includes extra cast device icon

Project Member Reported by jdufault@chromium.org, Jun 2 2016

Issue description

See b/29073993.

It looks like the media router (as of m52) adds a media sink that doesn't have a name. We shouldn't show it in the cast system tray UI.
 
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 2 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by amp@chromium.org, Jun 2 2016

Labels: -M-53 -MovedFrom-52 M-52
This is blocking the Chrome Media Router launch on 52.  Moving back to M52.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf25cc62ff3ba880f03e8869f59ddefdc21c89e

commit cdf25cc62ff3ba880f03e8869f59ddefdc21c89e
Author: jdufault <jdufault@chromium.org>
Date: Thu Jun 02 18:43:38 2016

Hide media sinks that don't have a name in the cast system tray.

This also hides media sinks that have a domain, as a temporary fix to meet privacy requirements. The logic to decide if a sink with a domain should be displayed will be added later.

BUG= 616683 

Review-Url: https://codereview.chromium.org/2029963002
Cr-Commit-Position: refs/heads/master@{#397481}

[modify] https://crrev.com/cdf25cc62ff3ba880f03e8869f59ddefdc21c89e/chrome/browser/ui/ash/cast_config_delegate_media_router.cc

Labels: Merge-Request-52

Comment 6 by tin...@google.com, Jun 3 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)

Comment 7 by kolos@chromium.org, Jun 6 2016

Components: Privacy

Comment 8 by amp@chromium.org, Jun 6 2016

Will this make it in for the CrOS 52 beta scheduled for this week?
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 6 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e7f2e196665120e0d580e2ea57c17783afbcaf5

commit 6e7f2e196665120e0d580e2ea57c17783afbcaf5
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Jun 06 17:52:15 2016

Hide media sinks that don't have a name in the cast system tray.

This also hides media sinks that have a domain, as a temporary fix to meet privacy requirements. The logic to decide if a sink with a domain should be displayed will be added later.

BUG= 616683 

Review-Url: https://codereview.chromium.org/2029963002
Cr-Commit-Position: refs/heads/master@{#397481}
(cherry picked from commit cdf25cc62ff3ba880f03e8869f59ddefdc21c89e)

Review URL: https://codereview.chromium.org/2040003002 .

Cr-Commit-Position: refs/branch-heads/2743@{#240}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/6e7f2e196665120e0d580e2ea57c17783afbcaf5/chrome/browser/ui/ash/cast_config_delegate_media_router.cc

Re #8, I'm not sure; it depends on when the beta gets built. It should definitely be in beta scheduled after that one.
Status: Fixed (was: Started)
Labels: VerifyIn-55

Comment 13 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 14 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 15 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 16 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 17 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 19 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment