Device list in CrOS system tray includes extra cast device icon |
||||||||||||||||
Issue descriptionSee b/29073993. It looks like the media router (as of m52) adds a media sink that doesn't have a name. We shouldn't show it in the cast system tray UI.
,
Jun 2 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 2 2016
This is blocking the Chrome Media Router launch on 52. Moving back to M52.
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdf25cc62ff3ba880f03e8869f59ddefdc21c89e commit cdf25cc62ff3ba880f03e8869f59ddefdc21c89e Author: jdufault <jdufault@chromium.org> Date: Thu Jun 02 18:43:38 2016 Hide media sinks that don't have a name in the cast system tray. This also hides media sinks that have a domain, as a temporary fix to meet privacy requirements. The logic to decide if a sink with a domain should be displayed will be added later. BUG= 616683 Review-Url: https://codereview.chromium.org/2029963002 Cr-Commit-Position: refs/heads/master@{#397481} [modify] https://crrev.com/cdf25cc62ff3ba880f03e8869f59ddefdc21c89e/chrome/browser/ui/ash/cast_config_delegate_media_router.cc
,
Jun 2 2016
,
Jun 3 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 6 2016
,
Jun 6 2016
Will this make it in for the CrOS 52 beta scheduled for this week?
,
Jun 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e7f2e196665120e0d580e2ea57c17783afbcaf5 commit 6e7f2e196665120e0d580e2ea57c17783afbcaf5 Author: Jacob Dufault <jdufault@google.com> Date: Mon Jun 06 17:52:15 2016 Hide media sinks that don't have a name in the cast system tray. This also hides media sinks that have a domain, as a temporary fix to meet privacy requirements. The logic to decide if a sink with a domain should be displayed will be added later. BUG= 616683 Review-Url: https://codereview.chromium.org/2029963002 Cr-Commit-Position: refs/heads/master@{#397481} (cherry picked from commit cdf25cc62ff3ba880f03e8869f59ddefdc21c89e) Review URL: https://codereview.chromium.org/2040003002 . Cr-Commit-Position: refs/branch-heads/2743@{#240} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/6e7f2e196665120e0d580e2ea57c17783afbcaf5/chrome/browser/ui/ash/cast_config_delegate_media_router.cc
,
Jun 6 2016
Re #8, I'm not sure; it depends on when the beta gets built. It should definitely be in beta scheduled after that one.
,
Jun 6 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by jdufault@chromium.org
, Jun 2 2016