New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 616673 link

Starred by 3 users
Status: Fixed
Owner:
jonr...@chromium.org
Closed: Sep 2016
Cc:
█ moshayedi@chromium.org
█ ben@chromium.org
sadrul@chromium.org
dtapu...@chromium.org
mustaq@chromium.org
tdres...@chromium.org
sky@chromium.org
majidvp@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
mus

Blocking:
issue 631270



Sign in to add a comment

Cleanup ui::Event -> blink::WebInputEvent conversion

Project Member Reported by sadrul@chromium.org, Jun 2 2016 
We currently have code in //content/browser/renderer_host/web_input_event_aura.h|cc to create various ui::Event types into corresponding blink::WebInputEvent types. We also have a type-converter for ui::Event -> blink::WebInputEvent in //mojo/converters/blink/. There's no reason to have this in two places (and we most likely don't need the type-converters at all). We should move the conversion code into //ui/events/blink/, and use that from where we need it.

Comment 1 by tdres...@chromium.org, Jun 2 2016

Cc: dtapu...@chromium.org
+dtapuska@, who has been thinking about doing some event type unification that may impact/be impacted by this.

Comment 2 by sadrul@chromium.org, Aug 4 2016

Blocking: 631270
Owner: jonr...@chromium.org

Comment 3 by sadrul@chromium.org, Aug 4 2016

Cc: majidvp@chromium.org mustaq@chromium.org
 Issue 625727  has been merged into this issue.

Comment 4 by jonr...@chromium.org, Aug 9 2016

Status: Started (was: Available)

Comment 5 by jonr...@chromium.org, Aug 16 2016 

via sadrul@ in code review:

blink::WebGestureEvent MakeWebGestureEventFromNativeEvent

We should just remove this (maybe in a follow up CL). We do not receive gesture
events from the platform on Windows.

I think we can get rid of some of the builders from blink, and instead use the
code here in events/blink. You shouldn't do that in this CL, but something to
keep in mind.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2addcb7b7dafe269307a85a7f99b4da6cd2907fe

commit 2addcb7b7dafe269307a85a7f99b4da6cd2907fe
Author: jonross <jonross@chromium.org>
Date: Thu Aug 18 21:48:54 2016

Refactor WebInputEventAura to ui/events/blink

Refactor the current ui::Event to blink::WebInputEvent converters from content/browser/renderer_host/ to ui/events/blink.

This is so we can merge mojo/converters/blink with this code, to have one unified location for all of the conversions.

TEST=content_unittests, events_unittests, manual testing
BUG= 616673 

Review-Url: https://codereview.chromium.org/2234023002
Cr-Commit-Position: refs/heads/master@{#412942}

[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/BUILD.gn
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/renderer_host/input/motion_event_web.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/renderer_host/input/touch_emulator.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[delete] https://crrev.com/61f9069b46b9a41c04da869a93a21903ca072a58/content/browser/renderer_host/input/web_input_event_builders_win.h
[delete] https://crrev.com/61f9069b46b9a41c04da869a93a21903ca072a58/content/browser/renderer_host/input/web_input_event_util.cc
[delete] https://crrev.com/61f9069b46b9a41c04da869a93a21903ca072a58/content/browser/renderer_host/input/web_input_event_util.h
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/renderer_host/input/web_input_event_util_unittest.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/renderer_host/native_web_keyboard_event_aura.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/renderer_host/ui_events_helper.cc
[delete] https://crrev.com/61f9069b46b9a41c04da869a93a21903ca072a58/content/browser/renderer_host/web_input_event_aura.cc
[delete] https://crrev.com/61f9069b46b9a41c04da869a93a21903ca072a58/content/browser/renderer_host/web_input_event_aura.h
[delete] https://crrev.com/61f9069b46b9a41c04da869a93a21903ca072a58/content/browser/renderer_host/web_input_event_aura_unittest.cc
[delete] https://crrev.com/61f9069b46b9a41c04da869a93a21903ca072a58/content/browser/renderer_host/web_input_event_aurawin.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/content_browser.gypi
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/content_tests.gypi
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/content/test/BUILD.gn
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/tools/valgrind/gtest_exclude/content_unittests.gtest.txt
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/BUILD.gn
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/BUILD.gn
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/DEPS
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/blink_event_util.h
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/blink_event_util_unittest.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/input_scroll_elasticity_controller.h
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/input_scroll_elasticity_controller_unittest.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/scoped_web_input_event.cc
[add] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/web_input_event.cc
[add] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/web_input_event.h
[rename] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/web_input_event_builders_win.cc
[add] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/web_input_event_builders_win.h
[rename] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/web_input_event_builders_win_unittest.cc
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/web_input_event_traits.h
[modify] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/web_input_event_traits_unittest.cc
[add] https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe/ui/events/blink/web_input_event_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a247f7359d505fba360696f90456e040e9f75e

commit b7a247f7359d505fba360696f90456e040e9f75e
Author: jonross <jonross@chromium.org>
Date: Mon Aug 22 23:12:21 2016

Remove unused gesture event builder on windows

Remove a method that was TODO implement me, as we do not receive these events on window anyways.

TEST=events_unittests content_unittests
BUG= 616673 

Review-Url: https://codereview.chromium.org/2265133002
Cr-Commit-Position: refs/heads/master@{#413570}

[modify] https://crrev.com/b7a247f7359d505fba360696f90456e040e9f75e/ui/events/blink/web_input_event.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27bc053e0d9d7bd1a9cbcfa73a38d318eeef09bf

commit 27bc053e0d9d7bd1a9cbcfa73a38d318eeef09bf
Author: jonross <jonross@chromium.org>
Date: Thu Sep 01 15:18:44 2016

Merge the mojo blink type converter into ui/events/blink

The code in mojo/converters/blink/blink_input_event_type_converters was mostly duplicate of ui/events/blink/web_input_event.

This change merges in the difference, blink::WebTouchEvent conversion. The tests from mojo have been ported over.

Furthermore CompositorMusConnection has been updated to use ui/events/blink.

With no other callsites, the mojo type converter has been deleted

TEST=events_unittests, content_unittests
BUG= 616673 

Review-Url: https://codereview.chromium.org/2270953002
Cr-Commit-Position: refs/heads/master@{#415956}

[modify] https://crrev.com/27bc053e0d9d7bd1a9cbcfa73a38d318eeef09bf/content/renderer/mus/BUILD.gn
[modify] https://crrev.com/27bc053e0d9d7bd1a9cbcfa73a38d318eeef09bf/content/renderer/mus/compositor_mus_connection.cc
[modify] https://crrev.com/27bc053e0d9d7bd1a9cbcfa73a38d318eeef09bf/content/renderer/mus/compositor_mus_connection.h
[modify] https://crrev.com/27bc053e0d9d7bd1a9cbcfa73a38d318eeef09bf/mojo/BUILD.gn
[delete] https://crrev.com/ec1da671f97f53a3fa24505c80593229264941fd/mojo/converters/blink/BUILD.gn
[delete] https://crrev.com/ec1da671f97f53a3fa24505c80593229264941fd/mojo/converters/blink/DEPS
[delete] https://crrev.com/ec1da671f97f53a3fa24505c80593229264941fd/mojo/converters/blink/OWNERS
[delete] https://crrev.com/ec1da671f97f53a3fa24505c80593229264941fd/mojo/converters/blink/blink_input_events_type_converters.cc
[delete] https://crrev.com/ec1da671f97f53a3fa24505c80593229264941fd/mojo/converters/blink/blink_input_events_type_converters.h
[delete] https://crrev.com/ec1da671f97f53a3fa24505c80593229264941fd/mojo/converters/blink/blink_input_events_type_converters_unittest.cc
[delete] https://crrev.com/ec1da671f97f53a3fa24505c80593229264941fd/mojo/converters/blink/mojo_blink_export.h
[modify] https://crrev.com/27bc053e0d9d7bd1a9cbcfa73a38d318eeef09bf/ui/events/blink/web_input_event.cc
[modify] https://crrev.com/27bc053e0d9d7bd1a9cbcfa73a38d318eeef09bf/ui/events/blink/web_input_event.h
[modify] https://crrev.com/27bc053e0d9d7bd1a9cbcfa73a38d318eeef09bf/ui/events/blink/web_input_event_unittest.cc
[modify] https://crrev.com/27bc053e0d9d7bd1a9cbcfa73a38d318eeef09bf/ui/events/event.cc

Comment 9 by jonr...@chromium.org, Sep 9 2016

Status: Fixed (was: Started)

Comment 10 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment