New issue
Advanced search Search tips

Issue 616660 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

White "add bookmarks" bar creates awkward space above DevTools

Project Member Reported by lgar...@chromium.org, Jun 2 2016

Issue description

Chrome 53.0.2754.0 
OSX 10.11.5

What steps will reproduce the problem?
(1) Open the New Tab Page
(2) Open DevTools on the side (the default location for a new profile)

What is the expected output?
See stable.png for matching colors.

What do you see instead?
canary.png

I assume this is Material-related. shrike@, could you triage?
 
stable.png
745 KB View Download
canary.png
307 KB View Download
Components: -UI>Browser>NewTabPage Platform>DevTools>JavaScript
Labels: -Proj-MaterialDesign-NativeUI OS-Linux OS-Mac OS-Windows
Owner: ----
Status: Untriaged (was: Assigned)
[BookmarkBarToolbarView drawAsDetachedBubble:] fills the area with the color ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND.

theme_properties.cc shows that ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND is SK_ColorWHITE in Material Design mode, so apparently this is part of the MD spec. This issue should not be limited to just the Mac.

Handing over to the DevTools folks to triage.

Status: WontFix (was: Untriaged)
I think that we wouldn't fix it right now. Because it's reproducible only on NTP when DevTools is docked to the left.
...to the right?

The default placement of DevTools is now on the right.

In addition, if your goal is to work with DevTools anywhere but the page you already have open, the first thing you might do is open a new tab/window and open DevTools: is exactly this situation.

In particular, it is common to need to open DevTools before navigating to a website, e.g. to capture network information. It is also common to open a new tab before doing so, if you don't want to navigate any of your current tabs.

So, yes, it's only reproducible under these conditions, but these are the most common, straightforward conditions.

Is this WontFix "not worth our time" or "working as intended"? In the former case, would you accept more specific suggestions, or a CL?
Would it be possible to shrink the NTP bookmarks bar with the content area when DevTools is opened? See attached mock.
Bookmarks.png
203 KB View Download

Sign in to add a comment