Test CrOS Video Encode Accelerator integration to VideoTrackRecorder |
||||||||
Issue descriptionSome problems such as issue 615265 and issue 615513 showed that we need to test different CrOS board before integrating HW encode functionality. So, we should first disable the functionality and enable based on test results.
,
Jun 3 2016
Thanks! If r397550 does seem to help for bugs like 615265 and 615513, does it need to be merged into M52?
,
Jun 3 2016
Those two bugs are not MediaRecorder related, r397550 doesn't affect AppRTC loopback, just MediaRecorder. PS. For issue 615513 , I already made a patch for disabling HW H264 encode, and it is on the merge. It probably wouldnt affect issue 615265 though.
,
Jul 12 2016
Issue 616658 has been merged into this issue.
,
Jan 18 2017
,
Jan 18 2017
Bulk move Blink>MediaStream>Recording ---> Blink>MediaRecording
,
Mar 7 2017
,
Nov 29 2017
Hi, Can we enable VEA for ChromeOS now? We are developing recording functionality with MediaRecorder and enabling VEA would greatly increase FPS (6 => 26, on kevin).
,
Nov 29 2017
,
Dec 5 2017
,
Dec 8 2017
Besides #1, we also need video_WebRtcMediaRecorderHwDecodeUsed and video_WebRtcMediaRecorderPerf like Ricky suggested. #1: https://chromium-review.googlesource.com/#/c/chromiumos/third_party/autotest/+/813974/
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e90d1f741bc421afed9d655a375b3965e729e7a7 commit e90d1f741bc421afed9d655a375b3965e729e7a7 Author: Sheng-Hao Tsao <shenghao@google.com> Date: Mon Dec 18 15:52:22 2017 Test various codec in MediaRecorder We want to make sure all codecs are working fine in MediaRecorder, not just the default one. BUG= 616659 TEST=Run on minnie that the test passes Change-Id: I4abef51064992b111c7c941825bec9b28f7aa942 Reviewed-on: https://chromium-review.googlesource.com/813974 Commit-Ready: Sheng-hao Tsao <shenghao@google.com> Tested-by: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Ricky Liang <jcliang@chromium.org> [modify] https://crrev.com/e90d1f741bc421afed9d655a375b3965e729e7a7/client/site_tests/video_WebRtcMediaRecorder/video_WebRtcMediaRecorder.py [modify] https://crrev.com/e90d1f741bc421afed9d655a375b3965e729e7a7/client/site_tests/video_WebRtcMediaRecorder/loopback_mediarecorder.html
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e1363dca0963f5616d19a07cb26f2d7e4586052 commit 5e1363dca0963f5616d19a07cb26f2d7e4586052 Author: Sheng-Hao Tsao <shenghao@google.com> Date: Fri Dec 22 14:50:56 2017 Add histograms for MediaRecorder This CL adds 2 new MediaRecorder histograms, one for the errors HW encode encounters and one for whether HW encode is used. ChromeOS autotest (crrev.com/c/813974 and crrev.com/c/831318) will use them to determine if tests pass. BUG= 616659 TEST=Verified with autotests that the histograms appear. Change-Id: Id7533e1df7d2105490085eadda061a117b466d59 Reviewed-on: https://chromium-review.googlesource.com/831773 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#525992} [modify] https://crrev.com/5e1363dca0963f5616d19a07cb26f2d7e4586052/content/renderer/media_recorder/vea_encoder.cc [modify] https://crrev.com/5e1363dca0963f5616d19a07cb26f2d7e4586052/content/renderer/media_recorder/video_track_recorder.cc [modify] https://crrev.com/5e1363dca0963f5616d19a07cb26f2d7e4586052/tools/metrics/histograms/enums.xml [modify] https://crrev.com/5e1363dca0963f5616d19a07cb26f2d7e4586052/tools/metrics/histograms/histograms.xml
,
Dec 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/15f1c905700a3689a1e05c696fc79f7994224e5c commit 15f1c905700a3689a1e05c696fc79f7994224e5c Author: Sheng-Hao Tsao <shenghao@google.com> Date: Tue Dec 26 15:08:53 2017 Add test to verify HW encode is used in MediaRecorder This CL adds test to verify that HW encode is used when MediaRecorder records a video. BUG= 616659 TEST=Verified that the test passes on kevin and fails on minnie Change-Id: Ia563a46e03708e288faed522a21402b33c590f6b [add] https://crrev.com/15f1c905700a3689a1e05c696fc79f7994224e5c/client/site_tests/video_MediaRecorderHWEncodeUsed/control.vp9 [add] https://crrev.com/15f1c905700a3689a1e05c696fc79f7994224e5c/client/site_tests/video_MediaRecorderHWEncodeUsed/control.vp8 [add] https://crrev.com/15f1c905700a3689a1e05c696fc79f7994224e5c/client/site_tests/video_MediaRecorderHWEncodeUsed/video_MediaRecorderHWEncodeUsed.py [add] https://crrev.com/15f1c905700a3689a1e05c696fc79f7994224e5c/client/site_tests/video_MediaRecorderHWEncodeUsed/control.h264 [add] https://crrev.com/15f1c905700a3689a1e05c696fc79f7994224e5c/client/site_tests/video_MediaRecorderHWEncodeUsed/loopback_mediarecorder.html
,
Dec 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/208a53e68bded2ed3f90e0400a581d790b4d459f commit 208a53e68bded2ed3f90e0400a581d790b4d459f Author: Sheng-Hao Tsao <shenghao@google.com> Date: Tue Dec 26 15:08:54 2017 Hook up video_MediaRecorderHWEncodeUsed test Add video_MediaRecorderHWEncodeUsed to the autotest-chrome target. BUG= 616659 CQ-DEPEND=CL:823511 TEST=Verified that the test passes on kevin Change-Id: Iee8442ed9a03f6966391baa4fea3b1cd8f24e6a0 [modify] https://crrev.com/208a53e68bded2ed3f90e0400a581d790b4d459f/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/df810ca3b5ea377c6b74b1510b11f7aa7d5248a9 commit df810ca3b5ea377c6b74b1510b11f7aa7d5248a9 Author: Sheng-Hao Tsao <shenghao@google.com> Date: Thu Jan 04 15:35:43 2018 Add mkvparse to python libraries This CL adds mkvparse python library that MediaRecorderPerf test needs. (crrev.com/c/843997) BUG= 616659 TEST=Verified that MediaRecorderPerf passes Change-Id: I334cc763d76e6bda5603f9f7f85fd2601bb1202e Reviewed-on: https://chromium-review.googlesource.com/844043 Commit-Ready: Sheng-hao Tsao <shenghao@google.com> Tested-by: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Ricky Liang <jcliang@chromium.org> [add] https://crrev.com/df810ca3b5ea377c6b74b1510b11f7aa7d5248a9/dev-python/mkvparse/metadata.xml [add] https://crrev.com/df810ca3b5ea377c6b74b1510b11f7aa7d5248a9/dev-python/mkvparse/Manifest [modify] https://crrev.com/df810ca3b5ea377c6b74b1510b11f7aa7d5248a9/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild [add] https://crrev.com/df810ca3b5ea377c6b74b1510b11f7aa7d5248a9/dev-python/mkvparse/mkvparse-1.1.0-r1.ebuild [add] https://crrev.com/df810ca3b5ea377c6b74b1510b11f7aa7d5248a9/dev-python/mkvparse/mkvparse-1.1.0.ebuild
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea6aa85497d39aed85e91310d1a344381516a253 commit ea6aa85497d39aed85e91310d1a344381516a253 Author: Sheng-Hao Tsao <shenghao@google.com> Date: Mon Jan 08 10:39:14 2018 Change --disable-vaapi-accelerated-video-encode This CL changes --disable-vaapi-accelerated-video-encode flag to --disable-accelerated-video-encode so that it covers both VAAPI and V4L2. This is needed in video_MediaRecorderPerf autotest (crrev.com/c/843997). BUG= 616659 TEST=1) video_MediaRecorderPerf passes. 2) Apprtc uses HW encode when the flag is not set and SW encode when the flag is set. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9a0ed7e51bf20e38acb5787878dd68837b9e5ec7 Reviewed-on: https://chromium-review.googlesource.com/844010 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#527601} [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/chrome/browser/chromeos/login/chrome_restart_request.cc [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/content/gpu/gpu_main.cc [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/content/gpu/gpu_sandbox_hook_linux.cc [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/content/public/browser/gpu_utils.cc [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/content/public/common/content_switches.cc [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/content/public/common/content_switches.h [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/gpu/command_buffer/service/gpu_preferences.h [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/gpu/ipc/common/gpu_preferences.mojom [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/gpu/ipc/common/gpu_preferences_struct_traits.h [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/gpu/ipc/common/gpu_preferences_util_unittest.cc [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/media/gpu/gpu_video_encode_accelerator_factory.cc [modify] https://crrev.com/ea6aa85497d39aed85e91310d1a344381516a253/services/service_manager/sandbox/linux/sandbox_seccomp_bpf_linux.h
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/47a3723c21a388074afe8523fcf66546a0d85b69 commit 47a3723c21a388074afe8523fcf66546a0d85b69 Author: Sheng-Hao Tsao <shenghao@google.com> Date: Tue Jan 09 01:22:51 2018 Add MediaRecorderPerf test MediaRecorderPerf test is added to measure CPU usages and frame processing time of HW and SW H264 encoding for MediaRecorder. BUG= 616659 CQ-DEPEND=CL:844043, CL:844010 TEST=Verified that MediaRecorderPerf passes on kevin Change-Id: I55ba4e76484eee405de65d901c9983c84fbd4170 Reviewed-on: https://chromium-review.googlesource.com/843997 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Ricky Liang <jcliang@chromium.org> [add] https://crrev.com/47a3723c21a388074afe8523fcf66546a0d85b69/client/site_tests/video_MediaRecorderPerf/loopback_mediarecorder.html [add] https://crrev.com/47a3723c21a388074afe8523fcf66546a0d85b69/client/site_tests/video_MediaRecorderPerf/video_MediaRecorderPerf.py [modify] https://crrev.com/47a3723c21a388074afe8523fcf66546a0d85b69/client/cros/video/constants.py [add] https://crrev.com/47a3723c21a388074afe8523fcf66546a0d85b69/client/site_tests/video_MediaRecorderPerf/control.h264
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a71fba3cd878234e03a3e79490fb5ee19c428c7c commit a71fba3cd878234e03a3e79490fb5ee19c428c7c Author: Sheng-Hao Tsao <shenghao@google.com> Date: Wed Jan 10 23:44:43 2018 Fix emerge failure of autotest-chrome This CL modifies the importing logic of mkvparse to make it dynamically imported so that it won't be imported during test set up. This would fix the problem that mkvparse library can't be found in host environment during emerging the test. BUG= 616659 TEST=video_MediaRecorderPerf can be emerged and passes on kevin Change-Id: I635319da91bf5262e28e0897fd1ce037fded1903 Reviewed-on: https://chromium-review.googlesource.com/855977 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Ricky Liang <jcliang@chromium.org> [modify] https://crrev.com/a71fba3cd878234e03a3e79490fb5ee19c428c7c/client/site_tests/video_MediaRecorderPerf/video_MediaRecorderPerf.py
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/942fb5b4755bf5f18c30f4f1ef1896256783ee4f commit 942fb5b4755bf5f18c30f4f1ef1896256783ee4f Author: Sheng-Hao Tsao <shenghao@google.com> Date: Fri Jan 12 06:22:51 2018 Hook up video_MediaRecorderPerf test Add video_MediaRecorderPerf to the autotest-chrome target. BUG= 616659 CQ-DEPEND=CL:843997, CL:855977 TEST=Verified that the test passes on kevin Change-Id: Ic3970a8ce96aaebec47e7cf92c3d60b94ea2e26b Reviewed-on: https://chromium-review.googlesource.com/843998 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Ricky Liang <jcliang@chromium.org> [modify] https://crrev.com/942fb5b4755bf5f18c30f4f1ef1896256783ee4f/virtual/target-chromium-os-test/target-chromium-os-test-1.ebuild [modify] https://crrev.com/942fb5b4755bf5f18c30f4f1ef1896256783ee4f/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a7e73df6dec1ce1a12ad1d2e4ba063b6162529a4 commit a7e73df6dec1ce1a12ad1d2e4ba063b6162529a4 Author: Sheng-Hao Tsao <shenghao@google.com> Date: Fri Jan 12 13:49:44 2018 Enable MediaRecorderHWEncodeUsed test in bvt-perbuild This CL enables video_MediaRecorderHWEncodeUsed to bvt-perbuild suite. After HW encode for MediaRecorder is turned on, I will change it to bvt-cq. BUG= 616659 TEST=No test Change-Id: I99a722d4e29ac8c0df898c9406dfe0b0582df218 Reviewed-on: https://chromium-review.googlesource.com/863345 Commit-Ready: Sheng-hao Tsao <shenghao@google.com> Tested-by: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Ricky Liang <jcliang@chromium.org> [modify] https://crrev.com/a7e73df6dec1ce1a12ad1d2e4ba063b6162529a4/client/site_tests/video_MediaRecorderHWEncodeUsed/control.vp9 [modify] https://crrev.com/a7e73df6dec1ce1a12ad1d2e4ba063b6162529a4/client/site_tests/video_MediaRecorderHWEncodeUsed/control.vp8 [modify] https://crrev.com/a7e73df6dec1ce1a12ad1d2e4ba063b6162529a4/client/site_tests/video_MediaRecorderHWEncodeUsed/control.h264
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecbec05c91d749e9d20ef3e0c8568cce5a87b4c5 commit ecbec05c91d749e9d20ef3e0c8568cce5a87b4c5 Author: Sheng-Hao Tsao <shenghao@google.com> Date: Wed Jan 17 10:04:35 2018 Enable HW VEA in MediaRecorder for ChromeOS We are implementing recording functionality in chrome camera app on ChromeOS devices with MediaRecorder APIs. Enabling HW VEA would greatly improve the performance. For example, FPS increases from 7 to 30 on kevin. BUG= 616659 TEST=Tested on kevin that chrome camera app can record videos. Change-Id: I9a3bce68b71dbd98b3311b3a21cf163ff6940929 Reviewed-on: https://chromium-review.googlesource.com/808444 Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#529689} [modify] https://crrev.com/ecbec05c91d749e9d20ef3e0c8568cce5a87b4c5/content/renderer/media_recorder/video_track_recorder.cc
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fdf988347a2c70d1ac7b92c2399d6b900f176ec4 commit fdf988347a2c70d1ac7b92c2399d6b900f176ec4 Author: Sheng-Hao Tsao <shenghao@google.com> Date: Fri Jan 19 01:40:34 2018 Upload test result of MediaRecorderPerf to dashboard This CL makes the result of video_MediaRecorderPerf results automatically uploaded to chrome perf dashboard. BUG= 616659 TEST=None Change-Id: I5a92f6f4ff63e449f02a929883ceb16be9565fca Reviewed-on: https://chromium-review.googlesource.com/867813 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Ricky Liang <jcliang@chromium.org> [modify] https://crrev.com/fdf988347a2c70d1ac7b92c2399d6b900f176ec4/tko/perf_upload/perf_dashboard_config.json
,
Jan 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bf960db6202a49c5a58beb3be3f24986bc9f7c09 commit bf960db6202a49c5a58beb3be3f24986bc9f7c09 Author: Sheng-Hao Tsao <shenghao@google.com> Date: Sat Jan 20 01:18:12 2018 Report partial result of MediaRecorderPerf This CL enables reporting partial result of MediaRecorderPerf test. Before this CL, if HW histogram verifier fails, the test would abort and report nothing. BUG= 616659 TEST=The test passes on kevin. Change-Id: I189ee6897bfd3bbbade7618e0a90818ac9a4c86d Reviewed-on: https://chromium-review.googlesource.com/867795 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Ricky Liang <jcliang@chromium.org> [modify] https://crrev.com/bf960db6202a49c5a58beb3be3f24986bc9f7c09/client/site_tests/video_MediaRecorderPerf/video_MediaRecorderPerf.py
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 3 2016