New issue
Advanced search Search tips

Issue 616654 link

Starred by 1 user
Status: Fixed
Owner:
hayato@chromium.org
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Event.composed flag should be set properly

Project Member Reported by hayato@chromium.org, Jun 2 2016 
See the context:
https://codereview.chromium.org/2012423004

DOM standard requires that a composed flag is false in default.

However, Blink is still using a list of events (See Event::isScoped), whose composed flag is *false* in default.

Instead of this list, we should have a list of events, whose composed flag should be *true* in default to note the exceptional cases.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/557ec07b3ab3b1535e71f86310f38b3517acc980

commit 557ec07b3ab3b1535e71f86310f38b3517acc980
Author: hayato <hayato@chromium.org>
Date: Fri Jun 03 11:19:18 2016

Set Event.composed flag correctly for some of UA UIEvents

See https://github.com/w3c/webcomponents/issues/513 for the context.

See also the previous CL: https://codereview.chromium.org/2012423004, where
Event.composed was introduced.

The change is visible only when Shadow DOM v1 is used.

BUG= 531990 , 616654 

Review-Url: https://codereview.chromium.org/2030243004
Cr-Commit-Position: refs/heads/master@{#397681}

[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/CompositionEvent.cpp
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/Event.cpp
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/Event.h
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/FocusEvent.cpp
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/TextEvent.cpp
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/UIEvent.cpp
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/UIEvent.h
[modify] https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980/third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp

Comment 2 by hayato@chromium.org, Jun 30 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment