New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616647 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 543161



Sign in to add a comment

Move SafeBrowsing V4 Caching to V4GetHashProtocolManager

Project Member Reported by kcaratt...@chromium.org, Jun 2 2016

Issue description

Move SafeBrowsing V4 Caching to V4GetHashProtocolManager. It is currently in the SafeBrowsingDatabaseManager but does not need to be exposed there.
 

Comment 1 by vakh@chromium.org, Jun 3 2016

Labels: SafeBrowsing-Triaged

Comment 2 by vakh@chromium.org, Aug 18 2016

Blocking: 543161

Comment 3 by vakh@chromium.org, Aug 26 2016

Cc: -vakh@chromium.org kcaratt...@chromium.org
Owner: vakh@chromium.org
Status: Started (was: Assigned)
Taking over the bug since I am re-designing the cache and moving it into V4GetHashProtocolManager.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d2b239717bd198bd42f11e468e1eaca6b94cdc1

commit 1d2b239717bd198bd42f11e468e1eaca6b94cdc1
Author: vakh <vakh@chromium.org>
Date: Tue Sep 13 18:23:51 2016

Move the logic to cache the full hash responses from the server into v4_get_hash_protocol_manager.

Design doc: https://goto.google.com/design-doc-v4-full-hash-manager

Overall, this CL does the following:
1. Moves caching to V4GetHashProtocolManager.
2. Refactors V4GetHashProtocolManager to use the data structures used in rest of
the V4 code.
3. Re-defines how cache is implemented.

TODOs:
1. Done: Merge the response from the server and the response from the cache.
2. Figure out what UMA metrics to add (I have removed some that are no longer
valid after the refactor).

BUG= 616647 ,  543161 

Review-Url: https://codereview.chromium.org/2233103002
Cr-Commit-Position: refs/heads/master@{#418303}

[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/BUILD.gn
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/database_manager.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/database_manager.h
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/database_manager_unittest.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/testing_util.h
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/util.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/util.h
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_database.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_database.h
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_database_unittest.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_get_hash_protocol_manager.h
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_local_database_manager.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_local_database_manager.h
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_local_database_manager_unittest.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_protocol_manager_util.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_protocol_manager_util.h
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_store.cc
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/components/safe_browsing_db/v4_store.h
[modify] https://crrev.com/1d2b239717bd198bd42f11e468e1eaca6b94cdc1/tools/metrics/histograms/histograms.xml

Comment 5 by vakh@chromium.org, Sep 13 2016

Status: Fixed (was: Started)

Sign in to add a comment