Race condition in DevTools requires UI thread hop in URLRequestChromeJob::Start() |
||||
Issue descriptionVersion: 53.0.2755.0 OS: Mac As we discovered in issue 616282 , there's a race condition that breaks most buttons and panels of undocked DevTools on Mac if we remove the UI thread hop from URLRequestChromeJob::Start(). (See caseq@'s comment 8 for the diagnosis.) This became a problem after landing r396193, which cleaned up some unused code for issue 614808 . We reverted that CL in r397006, but we plan to partially reland it while preserving the UI thread hop for Dev Tools for the moment. We should track down the race condition and get it fixed so that the legacy thread hop can also be removed.
,
Jun 2 2016
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5a831f23ed6fdfed5507e5ce9766a7df5d4203c commit f5a831f23ed6fdfed5507e5ce9766a7df5d4203c Author: creis <creis@chromium.org> Date: Thu Jun 02 22:24:19 2016 Remove obsolete StoragePartition check from old iframe signin path. For now, leave the UI thread hop in place for DevTools URLs, due to issue 616641 . BUG= 614808 , 616282 , 616641 TEST=Signin and Mac DevTools still work. Review-Url: https://codereview.chromium.org/2033563002 Cr-Commit-Position: refs/heads/master@{#397530} [modify] https://crrev.com/f5a831f23ed6fdfed5507e5ce9766a7df5d4203c/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/f5a831f23ed6fdfed5507e5ce9766a7df5d4203c/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/f5a831f23ed6fdfed5507e5ce9766a7df5d4203c/content/browser/webui/url_data_manager_backend.cc [modify] https://crrev.com/f5a831f23ed6fdfed5507e5ce9766a7df5d4203c/content/public/browser/content_browser_client.h
,
Oct 4 2017
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/625fd79e112f07c841b49d76b3c702a0acb43d09 commit 625fd79e112f07c841b49d76b3c702a0acb43d09 Author: Andrey Kosyakov <caseq@chromium.org> Date: Thu Dec 20 01:45:11 2018 Remove a workaround for race in DevToolsDataSource::StartDataRequest() I can't reproduce the race anymore and suspect that it is gone with https://chromium-review.googlesource.com/1229198, which has stopped relying on interception to support debug_devtools mode. Bug: 616641 Change-Id: I31ffbc52ff5fcac1e28a677bbc03c7ea9c6bca0b Reviewed-on: https://chromium-review.googlesource.com/c/1385116 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#618069} [modify] https://crrev.com/625fd79e112f07c841b49d76b3c702a0acb43d09/content/browser/webui/url_data_manager_backend.cc
,
Dec 20
|
||||
►
Sign in to add a comment |
||||
Comment 1 by caseq@chromium.org
, Jun 2 2016Owner: pfeldman@chromium.org