New issue
Advanced search Search tips

Issue 616631 link

Starred by 1 user
Status: Fixed
Owner:
brucedaw...@chromium.org
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

isolate.py fails on newly created gn output directory

Project Member Reported by brucedaw...@chromium.org, Jun 1 2016 
Repro steps:

> gn gen out\gn_new_dir
> ninja -C out\gn_new_dir base_unittests_run
> python tools\mb\mb.py isolate out\gn_new_dir base_unittests
Must either specify a path to an existing GN build dir or pass in a -m/-b pair or a -c flag to specify the configuration

This failure occurs because mb.py looks for args.gn and gn directories are not guaranteed to have such a file.

The workaround is to run "gn args out\gn_new_dir" to create a default (empty) args.gn file, but a proper fix should handle this by looking for toolchain.ninja and then handling the missing args.gn file.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecc0c1cd87f50efda32b82494c0c12b27798264b

commit ecc0c1cd87f50efda32b82494c0c12b27798264b
Author: brucedawson <brucedawson@chromium.org>
Date: Thu Jun 02 18:24:58 2016

Update mb.py to support gn directories with no args.gn

A newly generated gn directory doesn't have an args.gn file so mb.py
needs to account for that. This is done by using toolchain.ninja to
identify a gn directory, and by teaching GNValsFromDir to handle a
missing args.gn file. The unittest was also updated to provide the
toolchain.ninja file.

BUG= 616631 

Review-Url: https://codereview.chromium.org/2027823002
Cr-Commit-Position: refs/heads/master@{#397476}

[modify] https://crrev.com/ecc0c1cd87f50efda32b82494c0c12b27798264b/tools/mb/mb.py
[modify] https://crrev.com/ecc0c1cd87f50efda32b82494c0c12b27798264b/tools/mb/mb_unittest.py

Comment 2 by brucedaw...@chromium.org, Jun 3 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment