New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616622 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add expiration check for getters in offline_page_models. Fix consistency check.

Project Member Reported by romax@chromium.org, Jun 1 2016

Issue description

Add expiration check when GetAllPages/GetPages....
 

Comment 1 by romax@chromium.org, Jun 7 2016

Summary: Add expiration check for getters in offline_page_models. Fix consistency check. (was: Add expiration check for getters in offline_page_models.)
Will also have consistency check changed in this bug.

Comment 2 by romax@chromium.org, Jun 7 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7

commit b057d1e7c41c04cad80cbd7232ebcfed293c9ee7
Author: romax <romax@chromium.org>
Date: Thu Jun 09 00:09:56 2016

[Offline Pages] Filtering expired pages and fix consistency check.

Filtering expired pages when querying offline pages. Using expiring
instead of removing page entries in consistency check. Also will remove
files in archive folder to which have no page entry pointing.

BUG= 616622 

Review-Url: https://codereview.chromium.org/2041983006
Cr-Commit-Position: refs/heads/master@{#398744}

[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/components/offline_pages/offline_page_model.h
[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/components/offline_pages/offline_page_model_impl.h
[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/components/offline_pages/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/components/offline_pages/offline_page_test_store.cc
[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/components/offline_pages/offline_page_test_store.h
[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/components/offline_pages/stub_offline_page_model.cc
[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/components/offline_pages/stub_offline_page_model.h
[modify] https://crrev.com/b057d1e7c41c04cad80cbd7232ebcfed293c9ee7/tools/metrics/histograms/histograms.xml

Comment 4 by romax@chromium.org, Jun 9 2016

Status: Fixed (was: Started)

Comment 5 by romax@chromium.org, Jun 15 2016

Issue 613764 has been merged into this issue.

Sign in to add a comment