Support CustomFrameViewAsh styling for mash app windows. |
||
Issue descriptionSupport CustomFrameViewAsh styling for mash app windows. 1) Run chrome --mash with the files app pinned; attempt to launch it. 2) Crash accessing ash::Shell on ToT@#397187; see the partial callstack: [24131:24131:0601/142656:FATAL:shell.cc(224)] Check failed: instance_. #0 0x7f5ebdcbc5ae base::debug::StackTrace::StackTrace() #1 0x7f5ebdd1452c logging::LogMessage::~LogMessage() #2 0x7f5eb21b14f0 ash::Shell::GetInstance() #3 0x7f5eb2135499 ash::FrameCaptionButtonContainerView::ShouldSizeButtonBeVisible() #4 0x7f5eb2135193 ash::FrameCaptionButtonContainerView::FrameCaptionButtonContainerView() #5 0x7f5eb21399cd ash::CustomFrameViewAsh::HeaderView::HeaderView() #6 0x7f5eb213abf6 ash::CustomFrameViewAsh::CustomFrameViewAsh() #7 0x7f5ec198ff8b ChromeNativeAppWindowViewsAuraAsh::CreateNonClientFrameView() #8 0x7f5eb2a061fb views::Widget::CreateNonClientFrameView() #9 0x7f5eb2a038fa views::Widget::Init() #10 0x7f5ec1a42f9f ChromeNativeAppWindowViews::InitializeDefaultWindow() #11 0x7f5ec1a44523 ChromeNativeAppWindowViews::InitializeWindow() #12 0x7f5ec198f5fa ChromeNativeAppWindowViewsAuraAsh::InitializeWindow() #13 0x7f5ec40a98d0 native_app_window::NativeAppWindowViews::Init() #14 0x7f5ec1c04d87 ChromeAppWindowClient::CreateNativeAppWindowImpl() #15 0x7f5ec172b5b1 ChromeAppWindowClient::CreateNativeAppWindow() #16 0x7f5ec09f540d extensions::AppWindow::Init() #17 0x7f5ec0802698 extensions::AppWindowCreateFunction::RunAsync() #18 0x7f5ec0a4e22b AsyncExtensionFunction::Run() #19 0x7f5ec0a512be extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal() #20 0x7f5ec0a50928 extensions::ExtensionFunctionDispatcher::Dispatch() #21 0x7f5ec0aa536c extensions::ExtensionWebContentsObserver::OnRequest() Returning null in ChromeNativeAppWindowViewsAuraAsh::CreateNonClientFrameView avoids the crash. (this uses the default frame view, which doesn't have CustomFrameViewAsh styling) We'll need to implement CustomFrameViewAsh styling (color, title, etc.) for mash frames.
,
Jun 2 2016
In the end we decided to support default frames in mash instead of CustomFrameViewAsh. What styling issues have you been seeing with frames?
,
Jun 2 2016
With my abandoned CL, I was getting a standard mash frame with the Files app. It had a gray border instead of blue, and repeated the 'Downloads' title from below. After syncing past your CL, the frame was blue and untitled, so this is probably moot. |
||
►
Sign in to add a comment |
||
Comment 1 by msw@chromium.org
, Jun 1 2016