New issue
Advanced search Search tips

Issue 616602 link

Starred by 1 user
Status: Verified
Owner:
juncai@chromium.org
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 577170



Sign in to add a comment

Enable bluetooth chooser for Chrome Apps on non-Mac desktops

Project Member Reported by juncai@chromium.org, Jun 1 2016 
As  bug 577170  described, a chooser dialog needs to be implemented on Chrome Apps so that WebBluetooth API can be used there. Since the chooser UI implementation is different for Mac and non-Mac, this issue tracks the chooser UI implementation on non-Mac desktops.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65ba5f961c774fe301c4955759cbddb0da1ad1dc

commit 65ba5f961c774fe301c4955759cbddb0da1ad1dc
Author: juncai <juncai@chromium.org>
Date: Fri Jun 10 04:34:54 2016

Implement bluetooth chooser for Chrome Apps on non-Mac desktops

This is the part 5 of enabling the chooser UIs for Bluetooth from
Apps to enable developers to make a transition.

This CL implements the chooser UI for Bluetooth from Apps on non-Mac
desktops.

BUG= 616602 ,  577170 

Review-Url: https://codereview.chromium.org/2033283002
Cr-Commit-Position: refs/heads/master@{#399094}

[modify] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/browser/extensions/chrome_extension_chooser_dialog.h
[modify] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/browser/ui/views/browser_dialogs_views.cc
[add] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
[add] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/browser/ui/views/extensions/chooser_dialog_view.h
[add] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc
[modify] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/chrome_tests.gypi

Comment 2 by juncai@chromium.org, Jun 14 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65ba5f961c774fe301c4955759cbddb0da1ad1dc

commit 65ba5f961c774fe301c4955759cbddb0da1ad1dc
Author: juncai <juncai@chromium.org>
Date: Fri Jun 10 04:34:54 2016

Implement bluetooth chooser for Chrome Apps on non-Mac desktops

This is the part 5 of enabling the chooser UIs for Bluetooth from
Apps to enable developers to make a transition.

This CL implements the chooser UI for Bluetooth from Apps on non-Mac
desktops.

BUG= 616602 ,  577170 

Review-Url: https://codereview.chromium.org/2033283002
Cr-Commit-Position: refs/heads/master@{#399094}

[modify] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/browser/extensions/chrome_extension_chooser_dialog.h
[modify] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/browser/ui/views/browser_dialogs_views.cc
[add] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
[add] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/browser/ui/views/extensions/chooser_dialog_view.h
[add] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc
[modify] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/65ba5f961c774fe301c4955759cbddb0da1ad1dc/chrome/chrome_tests.gypi

Comment 4 by kathrelk...@chromium.org, Aug 12 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment