New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616599 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Negate net error codes in report failure histograms

Project Member Reported by est...@chromium.org, Jun 1 2016

Issue description

HPKP and Expect-CT violations record UMA metrics when a report fails to send. The net error code recorded in the histogram should be negated to make the histograms more readable.
 

Comment 1 by f...@chromium.org, Jun 1 2016

which histograms?
Net.PublicKeyPinReportSendingFailure and SSL.ExpectCTReportFailure
Cc: dadrian@google.com

Comment 4 by f...@chromium.org, Jun 30 2016

Labels: -Type-Bug Type-Feature
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1

commit a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1
Author: estark <estark@chromium.org>
Date: Wed Jul 20 17:43:28 2016

Fix up certificate error reporting histograms

This CL adds a failure histogram for certificate error reporting,
similar to the histograms we have for Expect CT and HPKP reports.

It also negates the net error codes for Expect CT and HPKP histograms,
to match up with the histogram enums. (See  bug 616599 .)

BUG= 616599 , 596624 

Review-Url: https://codereview.chromium.org/2120683002
Cr-Commit-Position: refs/heads/master@{#406604}

[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/chrome/browser/ssl/chrome_expect_ct_reporter.cc
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/components/BUILD.gn
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/components/certificate_reporting/BUILD.gn
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/components/certificate_reporting/DEPS
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/components/certificate_reporting/error_reporter.cc
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/components/certificate_reporting/error_reporter_unittest.cc
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/components/components_tests.gyp
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/ios/chrome/browser/DEPS
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/ios/chrome/browser/ssl/ios_ssl_blocking_page.h
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/ios/chrome/ios_chrome.gyp
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/net/http/transport_security_state.cc
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/net/http/transport_security_state_unittest.cc
[modify] https://crrev.com/a79bbb7b735bfbc7b84518bdd6f166a2fb39f7c1/tools/metrics/histograms/histograms.xml

Comment 6 by est...@chromium.org, Jul 20 2016

Labels: M-54
Status: Fixed (was: Assigned)
Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label

Sign in to add a comment