New issue
Advanced search Search tips

Issue 616598 link

Starred by 1 user
Status: Verified
Owner:
juncai@chromium.org
Closed: Jun 2016
Cc:
reillyg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 577170



Sign in to add a comment

Refactor ChooserBubbleUiViewDelegate at chooser_bubble_ui_view.cc

Project Member Reported by juncai@chromium.org, Jun 1 2016 
As  bug 577170  described, a chooser dialog needs to be implemented on Chrome Apps so that WebBluetooth API can be used there. Since the chooser content view is the same for WebBluetooth on desktop and Chrome Apps, it is better to pull it out of ChooserBubbleUiViewDelegate so that it can be reused and thus reduce code redundancy.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69d8c2e016d84e8276aee3b7467b5129106af752

commit 69d8c2e016d84e8276aee3b7467b5129106af752
Author: juncai <juncai@chromium.org>
Date: Fri Jun 10 04:26:41 2016

Refactor ChooserBubbleUiViewDelegate

This is part 4 of enabling the chooser UIs for Bluetooth
from Apps to enable developers to make a transition.

Since the chooser content view is the same for WebBluetooth
on desktop and Chrome Apps, it is better to pull it out of
ChooserBubbleUiViewDelegate and have a class
ChooserContentView that can be reused.

BUG= 616598 ,  577170 , 618618

Review-Url: https://codereview.chromium.org/2029863002
Cr-Commit-Position: refs/heads/master@{#399085}

[add] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/browser/ui/views/chooser_content_view.cc
[add] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/browser/ui/views/chooser_content_view.h
[add] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/browser/ui/views/chooser_content_view_unittest.cc
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/test/BUILD.gn
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/components/OWNERS
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/components/chooser_controller.gypi
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/components/chooser_controller/BUILD.gn
[add] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/components/chooser_controller/mock_chooser_controller.cc
[add] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/components/chooser_controller/mock_chooser_controller.h

Comment 2 by juncai@chromium.org, Jun 14 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69d8c2e016d84e8276aee3b7467b5129106af752

commit 69d8c2e016d84e8276aee3b7467b5129106af752
Author: juncai <juncai@chromium.org>
Date: Fri Jun 10 04:26:41 2016

Refactor ChooserBubbleUiViewDelegate

This is part 4 of enabling the chooser UIs for Bluetooth
from Apps to enable developers to make a transition.

Since the chooser content view is the same for WebBluetooth
on desktop and Chrome Apps, it is better to pull it out of
ChooserBubbleUiViewDelegate and have a class
ChooserContentView that can be reused.

BUG= 616598 ,  577170 , 618618

Review-Url: https://codereview.chromium.org/2029863002
Cr-Commit-Position: refs/heads/master@{#399085}

[add] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/browser/ui/views/chooser_content_view.cc
[add] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/browser/ui/views/chooser_content_view.h
[add] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/browser/ui/views/chooser_content_view_unittest.cc
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/chrome/test/BUILD.gn
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/components/OWNERS
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/components/chooser_controller.gypi
[modify] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/components/chooser_controller/BUILD.gn
[add] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/components/chooser_controller/mock_chooser_controller.cc
[add] https://crrev.com/69d8c2e016d84e8276aee3b7467b5129106af752/components/chooser_controller/mock_chooser_controller.h

Comment 4 by kathrelk...@chromium.org, Aug 12 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment