New issue
Advanced search Search tips

Issue 616582 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

YCanvasExpansion should report its units as pixels instead of bytes

Project Member Reported by ryansturm@chromium.org, Jun 1 2016

Issue description

Change the units of Blink.DecodedImage.YCanvasExpansion/XCanvasExpansion to pixels instead of bytes. This measures the amount of pixel width/height the first frame dimensions overflows the canvas dimensions, so bytes makes little sense.
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c58f3559782e9baab49ebecb19463b9afe0a9b1

commit 4c58f3559782e9baab49ebecb19463b9afe0a9b1
Author: ryansturm <ryansturm@chromium.org>
Date: Thu Jun 09 18:38:16 2016

The units for the CanvasExpansion should be pixels

YCanvasExpansion and XCavnasExpansion both measure how much the image
canvas expanded due to first frame size being larger than canvas size.
The units are currently in bytes, but should be in pixels.

BUG= 616582 

Review-Url: https://codereview.chromium.org/2055633002
Cr-Commit-Position: refs/heads/master@{#398955}

[modify] https://crrev.com/4c58f3559782e9baab49ebecb19463b9afe0a9b1/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c58f3559782e9baab49ebecb19463b9afe0a9b1

commit 4c58f3559782e9baab49ebecb19463b9afe0a9b1
Author: ryansturm <ryansturm@chromium.org>
Date: Thu Jun 09 18:38:16 2016

The units for the CanvasExpansion should be pixels

YCanvasExpansion and XCavnasExpansion both measure how much the image
canvas expanded due to first frame size being larger than canvas size.
The units are currently in bytes, but should be in pixels.

BUG= 616582 

Review-Url: https://codereview.chromium.org/2055633002
Cr-Commit-Position: refs/heads/master@{#398955}

[modify] https://crrev.com/4c58f3559782e9baab49ebecb19463b9afe0a9b1/tools/metrics/histograms/histograms.xml

Sign in to add a comment