New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616573 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

OpenVPN displays spurious "disconnected" notification when reconnecting

Project Member Reported by cernekee@chromium.org, Jun 1 2016

Issue description

Chrome OS' builtin OpenVPN client has supported automatic reconnections on network changes for a long time, but only recently ( bug 514343 ) has the Chrome UI had a way to properly communicate the reconnection status to the user.  Currently the OpenVPN shill service passes through the Idle state (Online->Idle->Associating) which causes Chrome to do the following:

 - Pop up a notification saying "VPN disconnected"
 - Do not display the pulsing VPN badge on top of the wireless signal strength indicator
 - Display "Connecting to <VPN>" instead of "Reconnecting to <VPN>" in the tray menu

Change the logic in openvpn_driver.cc to mirror the new logic in third_party_vpn_driver.cc so the user experience is more consistent.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/38618ae30e6f5c19a7d6287a0de1210c4a0ffd33

commit 38618ae30e6f5c19a7d6287a0de1210c4a0ffd33
Author: Kevin Cernekee <cernekee@google.com>
Date: Wed Jun 01 22:00:40 2016

openvpn: Handle reconnections the same way as ThirdPartyVpnDriver

Use the new APIs and callbacks to clean up the way OpenVPN handles
link up/down/change events.  This fixes a couple of UI anomalies seen
when using OpenVPN.

BUG= chromium:616573 
TEST=`FEATURES=test emerge-link shill`
TEST=connect to openvpn server and add/remove network connections

Change-Id: I2adf24f6d645ebf5070697b9324da03de4a4d237
Reviewed-on: https://chromium-review.googlesource.com/348801
Commit-Ready: Kevin Cernekee <cernekee@chromium.org>
Tested-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@google.com>

[modify] https://crrev.com/38618ae30e6f5c19a7d6287a0de1210c4a0ffd33/mock_virtual_device.h
[modify] https://crrev.com/38618ae30e6f5c19a7d6287a0de1210c4a0ffd33/vpn/openvpn_driver.h
[modify] https://crrev.com/38618ae30e6f5c19a7d6287a0de1210c4a0ffd33/vpn/openvpn_driver.cc
[modify] https://crrev.com/38618ae30e6f5c19a7d6287a0de1210c4a0ffd33/vpn/openvpn_driver_unittest.cc

Status: Fixed (was: Untriaged)
Cc: tienchang@chromium.org jongkyuj@chromium.org
Status: Assigned (was: Fixed)
The chrome://settings page does not auto-refresh to reflect to correct connection status

Steps to repro:
1) connect to openvpn or any other vpn service.
2) Once connected, Click the dropdown menu and select preferred network.
3) Remove the connected service (in this case openvpn)

Expected Result: Chrome://settings and bottom tray should show updated service status.

Actual Result: Chrome://settings page does not auto-refresh to show the updated status. 

Workaround: Manually refreshing the page fixes it.
I am guessing this change may have caused a regression, if not I can open a new issue. 

Tested: Cyan-cheets 8530.5.0. logs@ 
https://cloud.google.com/console/storage/chromiumos-test-logs/bugfiles/cr/616573/

Cc: steve...@chromium.org
I think the lack of refresh on the chrome://settings VPN status is a KI, which will be addressed when the Settings page is rewritten?

https://code.google.com/p/chrome-os-partner/issues/detail?id=52303
Status: Fixed (was: Assigned)
Correct. If the problem persists in chrome://md-settings, we should file a new bug against that UI.

Either way we shouldn't re-open a fixed bug for a fairly different symptom.

Just to clarify: this bug is for the tray/notifications associated with OpenVPN reconnections, not the chrome://settings behavior.  It is possible that the CL that fixed this issue had unwanted side effects, so it is good that Aashutosh was looking out for possible regressions.

I don't even see VPN settings in chrome://md-settings (my build is about 1 week old).
We don't have an "Add Network" section yet when no VPN is configured. If a
VPN is configured it should be showing up .
Labels: VerifyIn-54

Comment 9 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 10 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 11 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 12 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 13 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment