DCHECK in SnapshotController |
||
Issue descriptionI can't repro after reinstalling Chrome. But here is the stack trace. I wonder if there is a case we aren't considering here. signal 6 (SIGABRT), code -6 in tid 2995 (oid.apps.chrome) pid: 2995, tid: 2995, name: oid.apps.chrome >>> com.google.android.apps.chrome <<< signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr -------- [FATAL:snapshot_controller.cc(48)] Check failed: state_ == State::kSnapshotPending. See the attached file for stack trace.
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9c88f7c6eb09ba85ea6fce0316a9f7639fdc40b commit b9c88f7c6eb09ba85ea6fce0316a9f7639fdc40b Author: dimich <dimich@chromium.org> Date: Thu Jun 02 22:46:42 2016 Remove overeager DCHECK in SnapshotController. The DCHECK is not needed because indeed the state of the controller can be 'kReady' as a result of calling Reset() on it. The scenario can be as following: - snapshot started - page is navigated while snapshot is in progress. This causes immediate Reset() on SnapshotController. - This may or may not cancel snapshot, but ultimately the RecentTabHelper will report that snapshot is completed. If the Reset() above already happened, the DCHECK will fire. It should not, since this is normal conditions. Also updated RecentTabHelper to stop posted tasks related to previous snapshot when page is re-navigated. Removed chack for IsErrorPage() since it will be done later by checking CanSavePage anyways. BUG= 616570 Review-Url: https://codereview.chromium.org/2030793002 Cr-Commit-Position: refs/heads/master@{#397535} [modify] https://crrev.com/b9c88f7c6eb09ba85ea6fce0316a9f7639fdc40b/chrome/browser/android/offline_pages/recent_tab_helper.cc [modify] https://crrev.com/b9c88f7c6eb09ba85ea6fce0316a9f7639fdc40b/components/offline_pages/snapshot_controller.cc [modify] https://crrev.com/b9c88f7c6eb09ba85ea6fce0316a9f7639fdc40b/components/offline_pages/snapshot_controller_unittest.cc
,
Jun 6 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dim...@chromium.org
, Jun 1 2016Status: Started (was: Untriaged)