New issue
Advanced search Search tips

Issue 616568 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 587995



Sign in to add a comment

Introduce 'total' into 'PaymentDetails'

Project Member Reported by rouslan@chromium.org, Jun 1 2016

Issue description

^^^^
 
Components: UI>Browser>Autofill>Payments Blink>Payments
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11f37c673b5fdbf558b295eb2749df391852e5d9

commit 11f37c673b5fdbf558b295eb2749df391852e5d9
Author: rouslan <rouslan@chromium.org>
Date: Sat Jun 04 00:51:17 2016

Add 'total' field to 'PaymentDetails'.

This patch adds the 'total' field to 'PaymentDetails' and makes
'displayItems' field optional. Additional tests in this patch:

 * 'total' is required.
 * 'total.value' cannot start with '-'.
 * Undefined and empty 'displayItems' are OK.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff77f02821f7663f

This patch also removes the no-longer-used 'id' from display items in
several tests.

BUG= 616568 

Review-Url: https://codereview.chromium.org/2030193002
Cr-Commit-Position: refs/heads/master@{#397867}

[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentInformation.java
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[add] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ShoppingCart.java
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/android/java_sources.gni
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/test/data/android/payments/dynamic_shipping.js
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/test/data/android/payments/free_shipping.js
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/chrome/test/data/android/payments/no_shipping.js
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/third_party/WebKit/LayoutTests/payments/payment-request-in-iframe.html
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.h
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 4 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/c087a286e89994d7f228e4300b4c123f785aa4ed

commit c087a286e89994d7f228e4300b4c123f785aa4ed
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Jun 03 23:10:42 2016

Labels: M-53
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment