New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616559 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 537368



Sign in to add a comment

Multiple build-ids being generated in some files...

Project Member Reported by cmt...@chromium.org, Jun 1 2016

Issue description

A recent change to ChromeOS is causing some files to be built with 2 build-ids.  The change went in early on May 21.  We are pretty sure we know which change it was and we are in the process of working out how best to fix this issue (or if we just need to revert the change).  This bug is to track the problem.  This is happening with both GCC & LLVM.

The issue can be seen by doing 'readelf -n' on a file with debug info. e.g.

readelf -n debug/chrome.debug

Displaying notes found at file offset 0x000001b0 with length 0x00000020:
  Owner                 Data size	Description
  GNU                  0x00000010	NT_GNU_ABI_TAG (ABI version tag)
    OS: Linux, ABI: 2.6.16

Displaying notes found at file offset 0x000001d0 with length 0x00000048:
  Owner                 Data size	Description
  GNU                  0x00000014	NT_GNU_BUILD_ID (unique build ID bitstring)
    Build ID: 13cda3ac16195769a7e90b81e06ddf669a1f8102
  GNU                  0x00000014	NT_GNU_BUILD_ID (unique build ID bitstring)
    Build ID: b8e9a5c0f361c4a713354a717ca045ac54448f0c
 
Here's the CL that caused this problem

https://chromium-review.googlesource.com/#/c/328800
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8c1d396c36d68348525d4a94b95bc5c79a19914f

commit 8c1d396c36d68348525d4a94b95bc5c79a19914f
Author: Caroline Tice <cmtice@google.com>
Date: Wed Jun 01 23:42:05 2016

[GCC] Don't mix -Wl,--build-id with -r flags.

The compiler wrapper recently added -W,--build-id.  This works most
of the time, but it should not be added if the -r or --relocatable
flag is passed to the compiler.  We have been seeing a few files with
multiple build ids as a result of the recent change.  This fixes that.

BUG= chromium:616559 
TEST=Tested in my chroot.

Change-Id: Ia2a59912e8e3bc17652861120a622fc76d99f222
Reviewed-on: https://chromium-review.googlesource.com/348880
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8c1d396c36d68348525d4a94b95bc5c79a19914f/sys-devel/gcc/files/sysroot_wrapper.hardened
[rename] https://crrev.com/8c1d396c36d68348525d4a94b95bc5c79a19914f/sys-devel/gcc/gcc-4.9.2-r126.ebuild

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Bulk verified
Blocking: 537368

Sign in to add a comment