Implement the PIN keyboard with required features |
||||
Issue descriptionThe PIN keyboard itself needs to align with the mocks, ie, the contents of the buttons, how they are positioned, their coloring. The keyboard is only partially implemented right now. For example, we need a delete/clear button, as well as error message support. Since the PIN keyboard is shared between settings and unlocking, not every element will be visible all the time. Some helpful links: 1: go/cros-quick-unlock-ux 2: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc&l=144 3: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
,
Jun 24 2016
,
Jun 24 2016
,
Jun 24 2016
Make sure to wait until the CL lands ;) since the test team will verify the changed behavior. Does the pending CL also include the red-lines changes?
,
Jun 25 2016
Nope the CL does not have the red-lines changes.
,
Jun 27 2016
Okay - this issue should probably stay open open until the red-line changes are completed.
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dc6e498d4721b0206777845591a5111e4f86349 commit 9dc6e498d4721b0206777845591a5111e4f86349 Author: sammiequon <sammiequon@chromium.org> Date: Fri Jul 01 19:03:48 2016 Pin keyboard matches red lines (go/cros-quick-unlock-ux). BUG= 616545 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2100203003 Cr-Commit-Position: refs/heads/master@{#403497} [modify] https://crrev.com/9dc6e498d4721b0206777845591a5111e4f86349/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html [modify] https://crrev.com/9dc6e498d4721b0206777845591a5111e4f86349/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js [modify] https://crrev.com/9dc6e498d4721b0206777845591a5111e4f86349/ui/login/account_picker/user_pod_row.css
,
Jul 1 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sammiequon@chromium.org
, Jun 22 2016