Animations are currently tied to layers, but we want to generalize this for SPv2.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51659f1ad58fc058ebb95907734ce6b2c887898d commit 51659f1ad58fc058ebb95907734ce6b2c887898d Author: vollick <vollick@chromium.org> Date: Tue Jun 07 20:05:19 2016 Use element id's for animations. The goal of this CL is to migrate cc's animation code away from layer id's in anticipation of SPv2. The ids chosen are a minor tweak on DOMNodeIds for blink. Other clients of cc may essentially continue using their respective layer id's as identifiers. cc itself remains ignorant of the semantic meaning of these ids, treating them as an opaque identifier. This change is extremely similar to loyso@'s earlier CL crrev.com/1944623002, the significant difference being the scheme for choosing the ids. Notable changes in this CL * Introduces an ElementId structure. * Augments DOMNodeIds in order to handle sub elements (eg, for scroll and link highlight layers). * Removal of ElementLayers from cc BUG= 616542 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1973083002 Cr-Commit-Position: refs/heads/master@{#398366} [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/BUILD.gn [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/animation/animation_host.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/animation/animation_host.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/animation/animation_host_perftest.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/animation/animation_player.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/animation/animation_player_unittest.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/animation/element_animations_unittest.cc [add] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/animation/element_id.cc [add] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/animation/element_id.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/animation/scroll_offset_animations.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/blink/web_layer_impl.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/blink/web_layer_impl.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/cc.gyp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/input/scroll_state_data.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/input/scroll_state_data.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/layers/layer.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/layers/layer.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/layers/layer_impl.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/layers/layer_impl.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/layers/layer_impl_unittest.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/layers/layer_unittest.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/layers/layer_utils_unittest.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/proto/BUILD.gn [add] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/proto/element_id.proto [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/proto/property_tree.proto [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/test/animation_test_common.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/test/animation_test_common.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/test/animation_timelines_test_common.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/test/animation_timelines_test_common.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/test/layer_test_common.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/layer_tree_host.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/layer_tree_host.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/layer_tree_impl.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/layer_tree_impl.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/mutator_host_client.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/property_tree.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/cc/trees/property_tree.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/animation/CompositorAnimations.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/animation/KeyframeEffect.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/blink_platform.gypi [add] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [add] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/web/LinkHighlightImpl.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/third_party/WebKit/public/platform/WebLayer.h [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/ui/compositor/layer.cc [modify] https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d/ui/compositor/layer_animator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8f64cb037cd9b5c9eda8419d6ab778662702a6e commit a8f64cb037cd9b5c9eda8419d6ab778662702a6e Author: vollick <vollick@chromium.org> Date: Wed Jun 08 13:42:34 2016 Revert of Use element id's for animations (patchset #34 id:650001 of https://codereview.chromium.org/1973083002/ ) Reason for revert: This caused: https://bugs.chromium.org/p/chromium/issues/detail?id=618286 Original issue's description: > Use element id's for animations. > > The goal of this CL is to migrate cc's animation code > away from layer id's in anticipation of SPv2. The ids > chosen are a minor tweak on DOMNodeIds for blink. > > Other clients of cc may essentially continue using > their respective layer id's as identifiers. cc itself > remains ignorant of the semantic meaning of these ids, > treating them as an opaque identifier. > > This change is extremely similar to loyso@'s earlier > CL crrev.com/1944623002, the significant difference > being the scheme for choosing the ids. > > Notable changes in this CL > * Introduces an ElementId structure. > * Augments DOMNodeIds in order to handle sub elements (eg, for scroll and link highlight layers). > * Removal of ElementLayers from cc > > BUG= 616542 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d > Cr-Commit-Position: refs/heads/master@{#398366} TBR=jbroman@chromium.org,ajuma@chromium.org,bokan@chromium.org,loyso@chromium.org,rbyers@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 616542 Review-Url: https://codereview.chromium.org/2049063002 Cr-Commit-Position: refs/heads/master@{#398537} [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/BUILD.gn [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/animation/animation_host.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/animation/animation_host.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/animation/animation_host_perftest.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/animation/animation_player.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/animation/animation_player_unittest.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/animation/element_animations_unittest.cc [delete] https://crrev.com/0ac3322e558157a4f333b81323f83bebfab95305/cc/animation/element_id.cc [delete] https://crrev.com/0ac3322e558157a4f333b81323f83bebfab95305/cc/animation/element_id.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/animation/scroll_offset_animations.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/blink/web_layer_impl.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/blink/web_layer_impl.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/cc.gyp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/input/scroll_state_data.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/input/scroll_state_data.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/layers/layer.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/layers/layer.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/layers/layer_impl.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/layers/layer_impl.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/layers/layer_impl_unittest.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/layers/layer_unittest.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/layers/layer_utils_unittest.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/proto/BUILD.gn [delete] https://crrev.com/0ac3322e558157a4f333b81323f83bebfab95305/cc/proto/element_id.proto [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/proto/property_tree.proto [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/test/animation_test_common.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/test/animation_test_common.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/test/animation_timelines_test_common.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/test/animation_timelines_test_common.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/test/layer_test_common.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/layer_tree_host.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/layer_tree_host.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/layer_tree_impl.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/layer_tree_impl.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/mutator_host_client.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/property_tree.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/cc/trees/property_tree.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/animation/CompositorAnimations.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/animation/KeyframeEffect.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/blink_platform.gypi [delete] https://crrev.com/0ac3322e558157a4f333b81323f83bebfab95305/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [delete] https://crrev.com/0ac3322e558157a4f333b81323f83bebfab95305/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/web/LinkHighlightImpl.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/third_party/WebKit/public/platform/WebLayer.h [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/ui/compositor/layer.cc [modify] https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e/ui/compositor/layer_animator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef2ae922636be42ce063a534496f162c587d0e76 commit ef2ae922636be42ce063a534496f162c587d0e76 Author: vollick <vollick@chromium.org> Date: Wed Jun 29 17:54:27 2016 Use element id's for animations. The goal of this CL is to migrate cc's animation code away from layer id's in anticipation of SPv2. The ids chosen are a minor tweak on DOMNodeIds for blink. Other clients of cc may essentially continue using their respective layer id's as identifiers. cc itself remains ignorant of the semantic meaning of these ids, treating them as an opaque identifier. This change is extremely similar to loyso@'s earlier CL crrev.com/1944623002, the significant difference being the scheme for choosing the ids. Notable changes in this CL * Introduces an ElementId structure. * Augments DOMNodeIds in order to handle sub elements (eg, for scroll and link highlight layers). * Removal of ElementLayers from cc BUG= 616542 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d Review-Url: https://codereview.chromium.org/1973083002 Cr-Original-Commit-Position: refs/heads/master@{#398366} Cr-Commit-Position: refs/heads/master@{#402863} [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/BUILD.gn [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/animation/animation_host.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/animation/animation_host.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/animation/animation_host_perftest.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/animation/animation_player.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/animation/animation_player_unittest.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/animation/element_animations_unittest.cc [add] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/animation/element_id.cc [add] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/animation/element_id.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/animation/scroll_offset_animations.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/blink/web_layer_impl.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/blink/web_layer_impl.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/cc.gyp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/input/scroll_state_data.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/input/scroll_state_data.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/layers/layer.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/layers/layer.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/layers/layer_impl.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/layers/layer_impl.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/layers/layer_impl_unittest.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/layers/layer_unittest.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/layers/layer_utils_unittest.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/proto/BUILD.gn [add] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/proto/element_id.proto [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/proto/property_tree.proto [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/test/animation_test_common.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/test/animation_test_common.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/test/animation_timelines_test_common.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/test/animation_timelines_test_common.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/test/layer_test_common.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/layer_tree_host.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/layer_tree_host.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/layer_tree_impl.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/layer_tree_impl.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/mutator_host_client.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/property_tree.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/cc/trees/property_tree.h [add] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/LayoutTests/virtual/threaded/animations/cancel-unattached-animation.html [add] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/LayoutTests/virtual/threaded/animations/resources/cancel-unattached-animation-frame.html [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/animation/CompositorAnimations.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/animation/KeyframeEffect.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/blink_platform.gypi [add] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [add] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/web/LinkHighlightImpl.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/third_party/WebKit/public/platform/WebLayer.h [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/ui/compositor/layer.cc [modify] https://crrev.com/ef2ae922636be42ce063a534496f162c587d0e76/ui/compositor/layer_animator.cc
In case anyone else runs into problems caused by this, see https://codereview.chromium.org/2141743002.
Is this bug done?
Comment 1 by bugdroid1@chromium.org
, Jun 7 2016