webkitpy: MockFileSystem.walk is incorrect. |
||
Issue description
FileSystem.walk is a wrapper for os.walk, which returns a generator object that recursively walks through subdirectories. For example, if we have a directory structure like this:
foo
├── bar
│ └── baz
├── a
├── b
└── c
Then `list(os.walk('foo'))` will return:
[
('foo', ['bar'], ['a', 'b', 'c']),
('foo/bar', [], ['baz'])
]
However, MockFileSystem.walk (https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py&l=207) returns a list with one tuple, so it can't be correct in this case.
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fe63658bfaffc335caf48c43f13a8716297291b commit 5fe63658bfaffc335caf48c43f13a8716297291b Author: raikiri <raikiri@google.com> Date: Fri Jun 03 02:39:52 2016 Fix MockFileSystem.walk and add test. BUG= 616529 Review-Url: https://codereview.chromium.org/2029823002 Cr-Commit-Position: refs/heads/master@{#397593} [modify] https://crrev.com/5fe63658bfaffc335caf48c43f13a8716297291b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py [modify] https://crrev.com/5fe63658bfaffc335caf48c43f13a8716297291b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py [modify] https://crrev.com/5fe63658bfaffc335caf48c43f13a8716297291b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
,
Jun 3 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by qyears...@chromium.org
, Jun 2 2016Status: Assigned (was: Available)