New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616529 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

webkitpy: MockFileSystem.walk is incorrect.

Project Member Reported by qyears...@chromium.org, Jun 1 2016

Issue description

FileSystem.walk is a wrapper for os.walk, which returns a generator object that recursively walks through subdirectories. For example, if we have a directory structure like this:

foo
├── bar
│   └── baz
├── a
├── b
└── c

Then `list(os.walk('foo'))` will return:

[
  ('foo', ['bar'], ['a', 'b', 'c']),
  ('foo/bar', [], ['baz'])
]


However, MockFileSystem.walk (https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py&l=207) returns a list with one tuple, so it can't be correct in this case.
 
Owner: raikiri@google.com
Status: Assigned (was: Available)

Comment 3 by raikiri@google.com, Jun 3 2016

Status: Fixed (was: Assigned)

Sign in to add a comment