Issue metadata
Sign in to add a comment
|
Re-enable smoothness.tough_filters_cases.reference on Android One Perf for next stable reference build |
||||||||||||||||||||
Issue descriptionhttps://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf%20%281%29?numbuilds=200 Most recent log: https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf%20%281%29/builds/2850/steps/smoothness.tough_filters_cases.reference/logs/stdio This test has been failing for over 200 runs. Only the reference one is failing, which crashes the browser. From the log, it looks to me that the apps are killed due to device low memory (not just Chrome, also other apps). senorblanco, should we disable the reference test?
,
Jun 1 2016
Hmm. Strange that only the reference build is failing. I suppose we could disable it for now, but presumably once we update the reference build, wouldn't it start passing again?
,
Jun 1 2016
Yes, assuming the next stable Chrome fixes the problem.
,
Jun 1 2016
In that case, I suggest you disable the test, and log a bug against the subsequent stable release to re-enable it. WDYT?
,
Jun 1 2016
SGTM
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8454ebfd9efc7418ed61e44a07947607418ab8c9 commit 8454ebfd9efc7418ed61e44a07947607418ab8c9 Author: zhenw <zhenw@chromium.org> Date: Wed Jun 01 22:41:38 2016 Disable smoothness.tough_filters_cases.reference on Android One Perf (1) TBR=nednguyen@google.com BUG= 616520 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/2031733002 Cr-Commit-Position: refs/heads/master@{#397273} [modify] https://crrev.com/8454ebfd9efc7418ed61e44a07947607418ab8c9/tools/perf/benchmarks/smoothness.py
,
Jun 2 2016
Downgrade to Pri-2. Please remember to re-enable the test when the reference build is updated to the next stable version.
,
Jun 3 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 7 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 18 2016
,
Aug 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e26768713260b6912d627639218ee1dcadd59364 commit e26768713260b6912d627639218ee1dcadd59364 Author: senorblanco <senorblanco@chromium.org> Date: Sat Aug 13 01:40:56 2016 Re-enable smoothness.tough_filters_cases.reference on Android One. This is a manual revert of 8454ebfd9efc7418ed61e44a07947607418ab8c9. Now that we have a new reference build, this should be working again. If not, we'll disable again. TBR=zhenw@chromium.org BUG= 616520 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2240933002 Cr-Commit-Position: refs/heads/master@{#411849} [modify] https://crrev.com/e26768713260b6912d627639218ee1dcadd59364/tools/perf/benchmarks/smoothness.py
,
Aug 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cba7292edf5364ac5d75244abd5e825183161c2 commit 6cba7292edf5364ac5d75244abd5e825183161c2 Author: senorblanco <senorblanco@chromium.org> Date: Sat Aug 13 14:14:03 2016 Revert of Re-enable smoothness.tough_filters_cases.reference on Android One. (patchset #1 id:1 of https://codereview.chromium.org/2240933002/ ) Reason for revert: Reference run still breaks when this is enabled. Original issue's description: > Re-enable smoothness.tough_filters_cases.reference on Android One. > > This is a manual revert of 8454ebfd9efc7418ed61e44a07947607418ab8c9. > > Now that we have a new reference build, this should be working again. > If not, we'll disable again. > > TBR=zhenw@chromium.org > BUG= 616520 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > Committed: https://crrev.com/e26768713260b6912d627639218ee1dcadd59364 > Cr-Commit-Position: refs/heads/master@{#411849} TBR=zhenw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 616520 Review-Url: https://codereview.chromium.org/2241123002 Cr-Commit-Position: refs/heads/master@{#411895} [modify] https://crrev.com/6cba7292edf5364ac5d75244abd5e825183161c2/tools/perf/benchmarks/smoothness.py
,
Aug 17 2016
As you can see above, I tried to re-enable this for M54, but it still seems to cause crashes in the reference build. Still strange, since it's not causing problems in the non-reference build. Perhaps the reference build has not been updated?
,
Dec 21 2016
,
Dec 22 2016
Adding Infra-Troopers. Tests with "Device Affinity:0" are purple. I also see that there is a blacklisted device AG860440I0A2AGC, don't know if these things are related.
,
Dec 22 2016
Reference build was most recently updated this week, and shouldn't be blocking a re-enable unless the test is using Chromium code not in stable yet. Picksi: were you trying to re-land the enable cl when you ran across the purple bot? Can you add a link to the failure?
,
May 15 2017
not a trooper issue. Also likely stale?
,
Aug 4 2017
This issue was created > 6 months ago. The perf waterfall has changed significantly since then. If this bug is still relevant, please re-open. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by zh...@chromium.org
, Jun 1 2016